feat: quickfix

[tjdevries]

I'm working on changing structure of how we store and manage entries.

Once I do that, we can store all the entries.

Once I do that, it should be relatively trivial to turn all the entries into quickfix items.

(still WIP and playing around with new ideas / simple data structures)

[elianiva]

I got this weird spacing using this branch.

[tjdevries]

Ah, I don't know that I've checked descending yet.

[tjdevries]

@elianiva is it fixed now?

[elianiva]

Yup, it has been fixed.

[elianiva]

simplescreenrecorder-2020-12-27_19.35.51.mp4

Found another issue. If your cursor is at the bottom of the list and you if you try to go down, it will broke the list.
Sometimes the cursor just dissappeared, sometimes the entire list got messed up, and sometimes it jumps to a random position and lost its highlight like I've shown in the vid. Hopefully my video is clear enough.

Update: After some more testing, this only occured if the list is full.

[tjdevries]

I think I fixed your issue, have to fix some testing code though.

[elianiva]

can confirm, it works now :)

[elianiva]

found an issue with the multiselect highlighting, notice how the highlight didn't get applied when my cursor is placed below the selection? It works fine after I move it above the selected item.

edit: apparently if we move the cursor upwards until it gets back to the bottom, it doesn't matter where we place the cursor, the highlight will work just fine. But if we move the cursor downwards until it gets back to the top, no matter where we place the cursor, the highlight won't get applied.

edit: did some more testing, this doesn't happen if we select multiple items that are close to each other. (second video)

simplescreenrecorder-2021-01-09_08.24.51.mp4

simplescreenrecorder-2021-01-09_08.32.26.mp4

[kkharji]

• toggle_selection should select the current line and move to the next line. (kinda expected behavior comming from ranger, although we should have an option to disable it)
• experienced the same issue from @elianiva report
• hitting enter after select a list of items (for fd picker case) doesn't open the selected files and add them to bufferlist, am I missing something?

@tjdevries is there any additional aspect would like me to test?

[Conni2461]

1. Do we wanna put LinkedList.lua into plenary?
2. selection_strategy = 'row' is broken but that is also broken in current master. Its initialized wrong with sorting_strategy = 'decending' and i kinda expect it to do something slightly different. Or at least a while ago i fixed it to something different. E.g. I am at row index 20 and after typing there are only 15 row entries left, i expect it to be on the last possible index but now it resets. It might be the scroller?!

Edit: Yes its the scroller it works correct with scroll_strategy = 'limit'. So lets have this issue low prio and we can fix that later. No one complained about it and i don't even think most of the people know or use the different selection_strategies 😆

Edit 2: I think a fix could be in Pickers:set_selection doing the scroller after self:can_select_row(). Nevertheless i was running into Error executing vim.schedule lua callback: ...lugged/telescope.nvim/lua/telescope/pickers/scroller.lua:66: Must never exceed max results: { result = 40, args = { 40 0 40 } } when using selection_strategy = 'row'. Reproduce steps are use row -> picker fd -> type garbage till no more results can be found.

[tjdevries]

For now, just ignore multi selection. I just fixed some bugs I noticed along the way. I will work on that next. This is primarily focused on sending to quickfix list and making sure that results show correctly

[kaddkaka]

@Conni2461 referred me to this PR for some scroller issues. So I hope it's ok that I mention this one here too:

Pressing <down> when the search result is empty generates an error that steals the focus for about 1 second (new inserted characters will not be seen for that second but show up later). The error is:

E5108: Error executing lua ...se/opt/telescope.nvim/lua/telescope/pickers/scroller.lua:66: Must never exceed max results: { result = 35, args = { 35 0 35 } }