Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: functions in entry_manager.lua, pickers.lua and linked_list.lua #927

Closed
wants to merge 8 commits into from

Conversation

l-kershaw
Copy link
Contributor

@l-kershaw l-kershaw commented Jun 20, 2021

Adds documentation for functions in entry_manager.lua and in pickers.lua.

Was having a think about how to implement scrolling of results (as discussed in #42) and realised I did not understand the purpose of most of the functions in these files. This PR is the result of me trying to figure this out.
(It is also hopefully a way for me to be told where I have misunderstood things 🤣)


TODO:

  • finish off documenting pickers.lua
  • add documentation for linked_list.lua

@l-kershaw l-kershaw force-pushed the picker_docs branch 2 times, most recently from 50d05eb to 71e3b88 Compare June 29, 2021 21:28
@l-kershaw l-kershaw changed the title docs: functions in entry_manager.lua and in pickers.lua docs: functions in entry_manager.lua, pickers.lua and linked_list.lua Jul 2, 2021
@l-kershaw l-kershaw requested a review from Conni2461 July 7, 2021 16:03

--- Create a new linked list
---@param opts table
--- @key track_at number: the index of the node to track
Copy link
Member

@Conni2461 Conni2461 Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@key is currently not a thing, but that also doesn't matter because right now we are not exporting documentation for this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, was just matching what had been done elsewhere

Comment on lines +589 to +581
---@param status table: table containing information on the picker
--- and associated windows. Generally obtained from `state.get_status`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi there is currently no multiline annotations (doesnt matter as long as we do not generate docs from it)

lua/telescope/pickers.lua Outdated Show resolved Hide resolved
lua/telescope/pickers.lua Outdated Show resolved Hide resolved
lua/telescope/pickers.lua Outdated Show resolved Hide resolved
Comment on lines +1038 to +1030
-- TODO: document what the purpose of this is
-- Currently only used in `Picker: get_result_completor`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completion callbacks can be registered via opts.on_complete basically functions that run after all items are proceeded once. Currently used in testing, but users could do anything with it.
and _on_complete is basically only calling all these registered callbacks

@Conni2461
Copy link
Member

This is mostly good but you always have to ask @tjdevries if you are working with systems that low level. He did wrote EVERYTHING here i also only read the code 😆

This is probably another good point to mention. I still want to move linked list into plenary (as mentioned here as well #293 (comment)) plenary.collections is currently a little "empty" 😆

Github Actions and others added 3 commits July 10, 2021 15:27
@l-kershaw
Copy link
Contributor Author

Closing in favour of #1554, as this PR is so out of date that the merge conflicts would be more trouble than its worth 😅

@l-kershaw l-kershaw closed this Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants