-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: functions in entry_manager.lua
, pickers.lua
and linked_list.lua
#927
Conversation
50d05eb
to
71e3b88
Compare
entry_manager.lua
and in pickers.lua
entry_manager.lua
, pickers.lua
and linked_list.lua
|
||
--- Create a new linked list | ||
---@param opts table | ||
--- @key track_at number: the index of the node to track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@key
is currently not a thing, but that also doesn't matter because right now we are not exporting documentation for this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, was just matching what had been done elsewhere
---@param status table: table containing information on the picker | ||
--- and associated windows. Generally obtained from `state.get_status` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi there is currently no multiline annotations (doesnt matter as long as we do not generate docs from it)
-- TODO: document what the purpose of this is | ||
-- Currently only used in `Picker: get_result_completor` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completion callbacks can be registered via opts.on_complete
basically functions that run after all items are proceeded once. Currently used in testing, but users could do anything with it.
and _on_complete
is basically only calling all these registered callbacks
This is mostly good but you always have to ask @tjdevries if you are working with systems that low level. He did wrote EVERYTHING here i also only read the code 😆 This is probably another good point to mention. I still want to move linked list into plenary (as mentioned here as well #293 (comment)) plenary.collections is currently a little "empty" 😆 |
skip-checks: true
This is a partial revert of commit 846e0ee.
Closing in favour of #1554, as this PR is so out of date that the merge conflicts would be more trouble than its worth 😅 |
Adds documentation for functions in
entry_manager.lua
and inpickers.lua
.Was having a think about how to implement scrolling of results (as discussed in #42) and realised I did not understand the purpose of most of the functions in these files. This PR is the result of me trying to figure this out.
(It is also hopefully a way for me to be told where I have misunderstood things 🤣)
TODO:
pickers.lua
linked_list.lua