Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cabal to install shellcheck and upgrade to shellcheck v0.4.5 #1320

Merged
merged 2 commits into from
Nov 23, 2016
Merged

Use Cabal to install shellcheck and upgrade to shellcheck v0.4.5 #1320

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5508f8d
[Tests] switch to use Cabal to install ShellCheck
PeterDaveHello Nov 23, 2016
4b4e71f
[shellcheck] disable "Check exit code directly" warning on line 273, 666
PeterDaveHello Nov 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ nvm_ensure_version_installed() {
local NVM_VERSION_DIR
if [ "${EXIT_CODE}" != "0" ] || ! nvm_is_version_installed "${LOCAL_VERSION}"; then
VERSION="$(nvm_resolve_alias "${PROVIDED_VERSION}")"
# shellcheck disable=SC2181
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed koalaman/shellcheck#782 to ask about this.

if [ $? -eq 0 ]; then
nvm_err "N/A: version \"${PROVIDED_VERSION} -> ${VERSION}\" is not yet installed."
nvm_err ""
Expand Down Expand Up @@ -663,6 +664,7 @@ nvm_alias() {
nvm_ls_current() {
local NVM_LS_CURRENT_NODE_PATH
NVM_LS_CURRENT_NODE_PATH="$(command which node 2> /dev/null)"
# shellcheck disable=SC2181
if [ $? -ne 0 ]; then
nvm_echo 'none'
elif nvm_tree_contains_path "$(nvm_version_dir iojs)" "${NVM_LS_CURRENT_NODE_PATH}"; then
Expand Down