bumped php to 8.0 and phpstan enhancements #143
Conversation
| paths: | ||
| - src | ||
| - tests | ||
| inferPrivatePropertyTypeFromConstructor: true | ||
| ignoreErrors: |
There was a problem hiding this comment.
We must keep this line as long as we support symfony/validator under 6.1
| }, | ||
| "require": { | ||
| "php": ">=7.4", | ||
| "php": ">=8.0", | ||
| "giggsey/libphonenumber-for-php": "^8.0", | ||
| "symfony/framework-bundle": "^4.4|^5.3|^6.0", |
There was a problem hiding this comment.
We can also remove any support above 5.4
There was a problem hiding this comment.
As well as the related code 👍
| include: | ||
| - php: '7.4' | ||
| symfony-require: 4.4.* | ||
| - php: '8.0' | ||
| symfony-require: 5.3.* | ||
| - php: '8.0' | ||
| symfony-require: 6.0.* | ||
| stability: dev | ||
| - php: '8.1' | ||
| symfony-require: 6.1.* | ||
| - php: '8.1' | ||
| symfony-require: 6.2.* | ||
| stability: dev |
There was a problem hiding this comment.
I think some refresh is needed here, i propose something like this :
include:
# Lowest Deps
- php: 8.0
symfony-require: 5.4.*
# LTS with latest stable PHP
- php: latest
symfony-require: 5.4.*
# Active release
- php: latest
symfony-require: 6.2.*
# Development release
- php: nightly
symfony-require: 6.3.*@dev
stability: dev
| /* | ||
| * This file is part of the Symfony2 PhoneNumberBundle. | ||
| * This file is part of the Symfony PhoneNumberBundle. |
| @@ -1,7 +1,9 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
Changing every file to strict types is not a bad idea by itself, but it is hazardous and requires double-checking every condition... I'm not sure of it since it would require a lot of work to merge this PR 🤔
There was a problem hiding this comment.
Since it's php-cs-fixer it can be easily removed . It can be done in another PR but it's must to leverage strict type.
No description provided.