Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Adds support for custom jwks URI when it cannot be constructed from issuer URI #708

Closed
wants to merge 4 commits into from

Conversation

vtajzich
Copy link
Contributor

@vtajzich vtajzich commented Mar 16, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

JWKS URI is based on Issuer URI by appending '/v1/keys'.

Issue Number: N/A

What is the new behavior?

JWKS URI can be constructed either by appending '/v1/keys' to Issuer URI or it could be provided in options in 'jwksUri' field.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@rudovjan
Copy link

Should solve #489

@dollysingh3192
Copy link

Hi @rudovjan / @denysoblohin-okta / okta-oidc-js Team,

I am using jwt-verifier on the backend which internally uses Okta-oidc-js monorepo.

I am facing an issue for which this PR has been raised for. I searched the open Pull Request section of this repository and found two relative fixes that have been reported here and here

I also checked the commits of this PR and are perfectly suited as per needs. I request you to please take some actions on it as we have a production release of our in-house SPA in upcoming months.

Please let me know, as I am also open to contribute in this PR, if anything is pending.

Thanks in advance!

@denysoblohin-okta
Copy link
Contributor

PR looks good, just needs to be rebased on master with resolving conflicts.

@dollysingh3192
Copy link

Hey @vtajzich,

If you give me permission of the forked Repository and add me as a collaborator. I will raise an MR for pending items.

Thanks!

@dollysingh3192
Copy link

@denysoblohin-okta / @rudovjan / okta-oidc-js Team,,

Conflicts have been resolved. Please review.

@dollysingh3192
Copy link

dollysingh3192 commented May 13, 2021

Hey @rudovjan / @denysoblohin-okta / okta-oidc-js Team,

As I said earlier we have an upcoming release in few months and I really wanna test this functionality on production. If you guys could me give any tentative date on this PR getting merged would be really very very helpful.

Thanks in advance.

@denysoblohin-okta
Copy link
Contributor

The feature is included in 2.3.0 release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants