-
Notifications
You must be signed in to change notification settings - Fork 232
Adds support for custom jwks URI when it cannot be constructed from issuer URI #708
Conversation
…be constructed from issuer URI
…be constructed from issuer URI
Should solve #489 |
Hi @rudovjan / @denysoblohin-okta / okta-oidc-js Team, I am using jwt-verifier on the backend which internally uses Okta-oidc-js monorepo. I am facing an issue for which this PR has been raised for. I searched the open Pull Request section of this repository and found two relative fixes that have been reported here and here I also checked the commits of this PR and are perfectly suited as per needs. I request you to please take some actions on it as we have a production release of our in-house SPA in upcoming months. Please let me know, as I am also open to contribute in this PR, if anything is pending. Thanks in advance! |
PR looks good, just needs to be rebased on master with resolving conflicts. |
Hey @vtajzich, If you give me permission of the forked Repository and add me as a collaborator. I will raise an MR for pending items. Thanks! |
@denysoblohin-okta / @rudovjan / okta-oidc-js Team,, Conflicts have been resolved. Please review. |
Hey @rudovjan / @denysoblohin-okta / okta-oidc-js Team, As I said earlier we have an upcoming release in few months and I really wanna test this functionality on production. If you guys could me give any tentative date on this PR getting merged would be really very very helpful. Thanks in advance. |
The feature is included in 2.3.0 release |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
JWKS URI is based on Issuer URI by appending '/v1/keys'.
Issue Number: N/A
What is the new behavior?
JWKS URI can be constructed either by appending '/v1/keys' to Issuer URI or it could be provided in options in 'jwksUri' field.
Does this PR introduce a breaking change?
Other information
Reviewers