Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Handles the case where issuer is the Org Authorization Server #978

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vijetmahabaleshwar-okta
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@mraible
Copy link

mraible commented May 13, 2021

@vijetmahabaleshwar-okta Can you please fix the conflict?

@@ -162,7 +162,8 @@ function verifyNonce(expected, nonce) {
}

function getJwksUri(options) {
return options.jwksUri ? options.jwksUri : options.issuer + '/v1/keys';
const baseUrl = options.issuer?.indexOf('/oauth2') > 0 ? options.issuer : options.issuer + '/oauth2'; // Handle org AS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Org AS doesn't contain /oauth2 in the URL. Append it in this case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants