Only apply orientation fix for iOS 13

[onevcat]

No description provided.

[dreampiggy]

@onevcat This may cause some, emm, bad effect :)

SwiftUI's Image(uiImage:) is not a good solution. Suggest to use Image(decorative:scale:orientation:) as much as possible.

See: SDWebImage/SDWebImageSwiftUI#177

[onevcat]

@dreampiggy Thanks for letting me know it.

Sigh. Why am I not surprised at all.. 😂

[onevcat]

@dreampiggy Tried the identical code in Kingfisher but not reproducible with the UIImage based Image view.

Not sure what am I missing here. But I am going to wait and see if there are any reports on this and then give it a fix if necessary then.

[dreampiggy]

Trying not set renderingMode. Because SwiftUI.Image does not need this modifier, but they can magically use the always original mode.

[onevcat]

Some more results:

@dreampiggy

These behaviors seems to be a little different from the original issue in SDWebImage. (In SDWebImage/SDWebImageSwiftUI#177 , the image is rendered as template even when .original rendering mode is set. Is it?)

Without any rendering mode changing, the image is also rendered originally. And both .original and .template work fine as expected. Can it be a system version related behavior? (say Apple has fixed it in some certain iOS version?)

I am going to dig it deeper to see if I can find anything.

[dreampiggy]

Seems KF works fine on this case.

Did you override the original UIImage with withRenderingMode ?

The disassemble result shows, if you create the Image with platform UIImage, the platform UIImage will be used to create UIBarButtonItem, then set it into UINavigationViewController. All of this is UIKit-based.

If you create Image with CGImage, the Graphics and HostingView will be used to create custom UIBarButton with customView API, not that with image API.

So differences result the strange behavior.

[onevcat]

No. There is no withRenderingMode overriding in this case here.

create the Image with platform UIImage...UIImage will be used to create UIBarButtonItem

create Image with CGImage...be used to create custom UIBarButton with customView API

Is it opposite? According to your disassembly result:

// ....
	if let uiImage = platformItem.platformItemImage {
	    let imageView = UIImageView(image: uiImage)
	    item = UIBarButtonItem(customView:imageView)
	} else if platformItem.decorative {
	    let image = UIImage(cgImge:platformItem.contents)
	    let renderingMode = context.flags.renderingMode ?? .alwaysOriginal
	    let image2 = image.renderingMode(renderingMode)
	    item = UIBarButtonItem(image: image2, .plain, target, selector))
	} else {
	   let hostingView = context.hostingView
	   item = UIBarButtonItem(customView:hostView)
	}

It seems that the platformItemImage (UIImage) goes to customView way, while the decorative (CGImage) goes to the image based API. (And as it is from an CGImage, a renderingMode in context has to be considered here).

Not sure how the platformItem is assembled in this pseudo code, but won't both KFImage and WebImage fall into the third (hostingView) statement? Both are wrapping the SwiftUI.Image into a Group I guess?

[onevcat]

I didn't yet have a chance to go deep into the assembly code yet. So maybe my understanding on it is totally wrong.

I'll check it later when I have more time.