Support unlimited disk cache time #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 73.63% (diff: 100%)@@ master #566 diff @@
==========================================
Files 21 21
Lines 2240 2242 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1654 1651 -3
- Misses 586 591 +5
Partials 0 0
|
yonaskolb
reviewed
Jan 26, 2017
| @@ -93,6 +93,7 @@ open class ImageCache { | |||
|
|
|||
| /// The longest time duration in second of the cache being stored in disk. | |||
| /// Default is 1 week (60 * 60 * 24 * 7 seconds). | |||
| /// Setting this to a negative value will make the disk cache never expiring. | |||
There was a problem hiding this comment.
setting this to 0 should have the same effect as negative
There was a problem hiding this comment.
It's intended to have only negative number for "forever". 0 means expiring immediately. And since there is a default non-zero value here, it is better to opt out 0 so we could avoid to introduce misunderstanding.
yonaskolb
reviewed
Jan 26, 2017
| @@ -475,7 +476,7 @@ open class ImageCache { | |||
|
|
|||
| let diskCacheURL = URL(fileURLWithPath: diskCachePath) | |||
| let resourceKeys: Set<URLResourceKey> = [.isDirectoryKey, .contentAccessDateKey, .totalFileAllocatedSizeKey] | |||
| let expiredDate = Date(timeIntervalSinceNow: -maxCachePeriodInSecond) | |||
| let expiredDate = (maxCachePeriodInSecond < 0) ? nil : Date(timeIntervalSinceNow: -maxCachePeriodInSecond) | |||
rain2540
pushed a commit
to rain2540/Kingfisher
that referenced
this pull request
Feb 28, 2017
Support unlimited disk cache time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #559