Introduced a 'backgroundColor' property on the RoundCornerImageProcessor #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sor allowing to specify a desired backgroud color for the output image
|
Reference results Initial state -> a background color outside of the rounded image (JPEG, rounded .topLeft and .bottomLeft) is white: After an implementation, a background is set to the same color as the CollectionView: Also, the blending is totally fine: |
|
LGTM! Thanks! |
|
Thank you! Any ETA for the update of the pod spec for this? |
|
@luruke I am creating a version for now. |
petarlazarov
pushed a commit
to dowjones-mobile/Kingfisher
that referenced
this pull request
Oct 6, 2021
Introduced a 'backgroundColor' property on the RoundCornerImageProcessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to specify a background color for the rounded output image.
According to the issue: #757