update proto to 0.15.0 #5064
Merged
update proto to 0.15.0 #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Mar 22, 2022
codeboten
force-pushed
the
codeboten/otlp-v0.15.0
branch
2 times, most recently
from
284797d to
de67d79
Compare
Codecov Report
@@ Coverage Diff @@
## main #5064 +/- ##
==========================================
- Coverage 91.03% 91.02% -0.02%
==========================================
Files 180 180
Lines 10810 10830 +20
==========================================
+ Hits 9841 9858 +17
- Misses 750 753 +3
Partials 219 219
Continue to review full report at Codecov.
|
This includes changes to support optional types: - update sed script to update optional type to oneof - bump proto to 0.15.0 - make genproto - update sum to OptionalType - InstrumentationLibraryMetrics -> ScopeMetrics - InstrumentationLibrarySpans -> ScopeSpans - InstrumentationLibraryLogs -> ScopeLogs
codeboten
force-pushed
the
codeboten/otlp-v0.15.0
branch
from
8fad461 to
4f7ac00
Compare
This was referenced Mar 23, 2022
bogdandrutu
approved these changes
Mar 24, 2022
| @@ -1430,12 +1430,18 @@ func (ms HistogramDataPoint) SetCount(v uint64) { | |||
|
|
|||
| // Sum returns the sum associated with this HistogramDataPoint. | |||
| func (ms HistogramDataPoint) Sum() float64 { | |||
| return (*ms.orig).Sum | |||
| return (*ms.orig).GetSum() | |||
There was a problem hiding this comment.
nit: separate PR we should update this comment that a "zero-initialized" value is returned if the value is not present (HasSum() == false)
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
This includes changes to support optional types: - update sed script to update optional type to oneof - bump proto to 0.15.0 - make genproto - update sum to OptionalType - InstrumentationLibraryMetrics -> ScopeMetrics - InstrumentationLibrarySpans -> ScopeSpans - InstrumentationLibraryLogs -> ScopeLogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes to support optional types:
Fixes #4258 #5071
Part of #5063