Deprecation of pdata methods following OTLP v0.15.0 #5076
Conversation
|
Does this implement the graceful transition rules or it will be in a separate PR? |
|
@tigrannajaryan it does not implement them yet. I will do so before marking it ready for review 👍 |
codeboten
force-pushed
the
codeboten/deprecate-instrumentation-library
branch
from
9adbe8a to
3972404
Compare
Codecov Report
@@ Coverage Diff @@
## main #5076 +/- ##
==========================================
- Coverage 90.00% 89.90% -0.10%
==========================================
Files 183 183
Lines 11040 11052 +12
==========================================
Hits 9936 9936
- Misses 882 894 +12
Partials 222 222
Continue to review full report at Codecov.
|
codeboten
force-pushed
the
codeboten/deprecate-instrumentation-library
branch
from
3972404 to
55d4787
Compare
Adding deprecation methods for the following pdata methods: - InstrumentationLibrary is now Scope - InstrumentationLibrarySpans is now ScopeSpans - InstrumentationLibraryLogs is now ScopeLogs - InstrumentationLibraryMetrics is now ScopeMetrics
codeboten
force-pushed
the
codeboten/deprecate-instrumentation-library
branch
from
e3f949c to
4425688
Compare
|
Sorry @tigrannajaryan I misinterpreted the question in your comment and thought you were talking about the whether this PR would include the deprecated methods to allow users of pdata to transition off of the old names. Those are now included in this PR. The update to support the transition rules will be done as a separate PR to address #5074 |
OK. Let's plan to do this work before the next release. We want the new release to handle the transition as it is described in the proto spec. |
|
💯 @tigrannajaryan i started here #5085 |
| @@ -51,24 +51,24 @@ var resourceLogs = &messageValueStruct{ | |||
| resourceField, | |||
| schemaURLField, | |||
| &sliceField{ | |||
| fieldName: "InstrumentationLibraryLogs", | |||
| fieldName: "ScopeLogs", | |||
There was a problem hiding this comment.
We still need to work with deprecated field InstrumentationLibraryLogs. I assume the field will be added back in #5085
) * Deprecation of pdata methods following OTLP v0.15.0 Adding deprecation methods for the following pdata methods: - InstrumentationLibrary is now Scope - InstrumentationLibrarySpans is now ScopeSpans - InstrumentationLibraryLogs is now ScopeLogs - InstrumentationLibraryMetrics is now ScopeMetrics * update changelog * add deprecated method on resource spans/metrics/logs * add InstrumentationLibrary deprecation method
Follow up to #5064
Adding deprecation methods for the following pdata methods:
Fixes #5073 #5072