[model/semconv] Add missing files for semconv v1.7.0 and v1.8.0 #5091
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5091 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 183 183
Lines 11023 11023
=======================================
Hits 9936 9936
Misses 865 865
Partials 222 222 Continue to review full report at Codecov.
|
dmitryax
force-pushed
the
add-missing-sem-conv-files
branch
2 times, most recently
from
40a90f7 to
4599cf3
Compare
dmitryax
force-pushed
the
add-missing-sem-conv-files
branch
from
4599cf3 to
7197b22
Compare
Some files that are supposed to be created manually were missed in semconv v1.7.0 and v1.8.0
dmitryax
force-pushed
the
add-missing-sem-conv-files
branch
from
7197b22 to
c81fe5c
Compare
|
@Aneurysm9 PTAL if the change of SchemaURL value is needed, or if there is any reason to keep the |
|
Ready for review. The schema URL is confirmed by @tigrannajaryan in #5103 |
| const ( | ||
| OtelLibraryName = "otel.library.name" | ||
| OtelLibraryVersion = "otel.library.version" | ||
| OtelStatusCode = "otel.status_code" | ||
| OtelStatusDescription = "otel.status_description" | ||
| ) |
There was a problem hiding this comment.
I assume this is an exact copy from 1.6.1 directory, right?
There was a problem hiding this comment.
Yes, it is. I didn't find any changes on these definitions up to 1.10.0
There was a problem hiding this comment.
If we managed to not have these (especially because they are manually written), is this a sign that we don't need them?
There was a problem hiding this comment.
If we managed to not have these (especially because they are manually written), is this a sign that we don't need them?
There was a problem hiding this comment.
If we managed to not have these (especially because they are manually written), is this a sign that we don't need them?
There was a problem hiding this comment.
Otherwise, what is our plan to not forget about these for the future?
There was a problem hiding this comment.
I can add a test verifying that the files are created
…-telemetry#5091) Some files that are supposed to be created manually were missed in semconv v1.7.0 and v1.8.0
Some files that are supposed to be created manually were missed in semconv v1.7.0 and v1.8.0