-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Semantic Convention Schema URL definition for 1.5.0 and 1.6.1 #5103
Conversation
This is technically a breaking change, so we need to make sure that this is needed indeed. I'll keep it in draft for now |
Codecov Report
@@ Coverage Diff @@
## main #5103 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 183 183
Lines 11023 11023
=======================================
Hits 9936 9936
Misses 865 865
Partials 222 222 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good fix.
/cc @tigrannajaryan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is definitely a bug. The correct URLs don't have "v" prefix, see the Schema Files directory: https://github.com/open-telemetry/opentelemetry-specification/tree/main/schemas
Since Schemas at OpenTelemetry are still Experimental we are free to make this breaking change (really a bug fix).
This change fixes the sem conv SchemaURL values, as reported in #5090 (comment)