Update aspnetcore benchmark results #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3688 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 283 283
Lines 10296 10296
=======================================
Hits 9037 9037
Misses 1259 1259
|
utpilla
approved these changes
Sep 21, 2022
Kielek
approved these changes
Sep 22, 2022
cijothomas
reviewed
Sep 22, 2022
test/Benchmarks/Instrumentation/AspNetCoreInstrumentationBenchmarks.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Sep 22, 2022
|
@vishweshbankwar can you rebase from main, so we can merge |
cijothomas
reviewed
Sep 22, 2022
| @@ -27,17 +27,17 @@ | |||
| /* | |||
| // * Summary * | |||
|
|
|||
| BenchmarkDotNet=v0.13.1, OS=Windows 10.0.22621 | |||
| BenchmarkDotNet=v0.13.2, OS=Windows 11 (10.0.22621.521) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates BenchmarkDotNet to
0.13.2which fixes the issue of rounding of memory allocation numbersFollow up on #3519 (comment)