-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASP.NET Core] Enable diagnostic source events using explicit names #3519
[ASP.NET Core] Enable diagnostic source events using explicit names #3519
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3519 +/- ##
==========================================
- Coverage 87.74% 87.64% -0.10%
==========================================
Files 283 283
Lines 10286 10296 +10
==========================================
- Hits 9025 9024 -1
- Misses 1261 1272 +11
|
…nosticSource-events
…nosticSource-events
src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreInstrumentation.cs
Show resolved
Hide resolved
…nosticSource-events
…nosticSource-events
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
…nosticSource-events
…e-events' of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/use-explicit-name-matching-for-diagnosticSource-events
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
…e-events' of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/use-explicit-name-matching-for-diagnosticSource-events
…nosticSource-events
…nosticSource-events
…nosticSource-events
| UninstrumentedAspNetCoreApp | 155.6 us | 2.63 us | 2.33 us | 0.9766 | 5 KB | | ||
| InstrumentedAspNetCoreAppWithDefaultOptions | 176.8 us | 3.24 us | 2.70 us | 1.2207 | 7 KB | | ||
| UninstrumentedAspNetCoreApp | 164.7 us | 1.66 us | 1.39 us | 0.9766 | 5 KB | | ||
| InstrumentedAspNetCoreAppWithDefaultOptions | 178.7 us | 2.65 us | 2.35 us | 0.9766 | 5 KB | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Might be good to add a entry in changelog to highlight the improved performance to motivate ppl to update to newer version. We usually do not add changelog for internal only changes, but the perf gain here should be worth mentioning.
…e-events' of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/use-explicit-name-matching-for-diagnosticSource-events
@vishweshbankwar Hey I think this PR might have broken stuff. I'm testing the AspNetCore instrumentation using the example app. Not seeing any spans when running in net6.0. Took me a while but I got here: Looks like a mismatch from what is being used vs what is defined? |
Towards #3495 .
Changes
This change will enable diagnostic source event subscription for asp.net core for the specified list of events.
ASP.NET Core library is using the best practices defined to write diagnostic source events.
Reference:
https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.Core/src/MvcCoreDiagnosticListenerExtensions.cs
https://github.com/dotnet/aspnetcore/blob/main/src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs
This may also help with some perf as it will prevent the payload creation and writing of non-desired events.
Also, this can be extended to other instrumentation libraries based on DiagnosticSource events.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes