Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET Core] Fix broken instrumentation #3709

Merged

Conversation

vishweshbankwar
Copy link
Member

Fixes ##3519 (comment)

This surfaced a gap in our tests. From my brief investigation, the issue is coming from here. This will enable activity creation and once the activity is created we were subscribing to .Start and .Stop events.

We probably need to test with and without builder.Logging.ClearProviders(). Will look in to this separately and update our tests accordingly.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar marked this pull request as ready for review September 29, 2022 21:36
@vishweshbankwar vishweshbankwar requested a review from a team September 29, 2022 21:36
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #3709 (a56b38b) into main (79ccb27) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3709      +/-   ##
==========================================
- Coverage   87.17%   87.06%   -0.11%     
==========================================
  Files         274      274              
  Lines       10008    10009       +1     
==========================================
- Hits         8724     8714      -10     
- Misses       1284     1295      +11     
Impacted Files Coverage Δ
...umentation.AspNetCore/AspNetCoreInstrumentation.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 75.00% <0.00%> (-10.00%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-8.83%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...Listener/Internal/PrometheusExporterEventSource.cs 61.11% <0.00%> (-5.56%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 72.52% <0.00%> (-2.20%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 82.25% <0.00%> (+2.41%) ⬆️
... and 1 more

@CodeBlanch CodeBlanch merged commit c40effd into open-telemetry:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants