Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasAttributesSatisfying(Consumer<Attributes> attributes) overload to AbstractPointAssert #6031

Closed
trask opened this issue Nov 29, 2023 · 2 comments
Closed

Add hasAttributesSatisfying(Consumer<Attributes> attributes) overload to AbstractPointAssert #6031

trask opened this issue Nov 29, 2023 · 2 comments
Labels
Feature Request Suggest an idea for this project good first issue help wanted

Comments

@trask
Copy link
Member

trask commented Nov 29, 2023

Add hasAttributesSatisfying(Consumer<Attributes> attributes) overload to AbstractPointAssert, to match similar overload in SpanDataAssert.

This method is useful for asserting against keys only (when you don't know or care about their values).
@trask trask added the Feature Request Suggest an idea for this project label Nov 29, 2023
chungngoops added a commit to chungngoops/opentelemetry-java that referenced this issue Dec 5, 2023
@chungngoops
add hasAttributesSatisfying overload to AbstractPointAssert
21222a0 
ref: open-telemetry#6031
@chungngoops chungngoops mentioned this issue Dec 5, 2023
Merged
@chungngoops
Copy link
Contributor

I created a draft PR because some tests are failing in my local, I'm checking to make sure my code doesn't make those tests fail.

chungngoops added a commit to chungngoops/opentelemetry-java that referenced this issue Dec 6, 2023
@chungngoops
add hasAttributesSatisfying overload to AbstractPointAssert
536c9de 
ref: open-telemetry#6031
chungngoops added a commit to chungngoops/opentelemetry-java that referenced this issue Dec 8, 2023
@chungngoops
add hasAttributesSatisfying overload to AbstractPointAssert
1710629 
ref: open-telemetry#6031
@jack-berg
Copy link
Member

Resolved in #6048.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Suggest an idea for this project good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@trask @jkwatson @chungngoops @jack-berg