-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hasAttributesSatisfying overload to AbstractPointAssert #6048
add hasAttributesSatisfying overload to AbstractPointAssert #6048
Conversation
|
I created a draft because some tests are failing in my local, I'm checking to make sure my code doesn't make those tests fail. |
606f421
to
536c9de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6048 +/- ##
============================================
- Coverage 91.18% 91.17% -0.01%
- Complexity 5623 5710 +87
============================================
Files 618 628 +10
Lines 16580 16725 +145
Branches 1642 1650 +8
============================================
+ Hits 15118 15249 +131
- Misses 1013 1021 +8
- Partials 449 455 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @chungngoops! can you add a test for this new overload?
@trask I added tests for that overload similar to other methods in that class, not sure that's enought or should I create a new dedicated test class for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
603fd72
to
1710629
Compare
ref: #6031