Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning of *DNS name prefix* in protobuf code comment for metric name #511

Closed
sebastien-rosset opened this issue Jan 23, 2023 · 0 comments · Fixed by #512
Closed

Comments

@sebastien-rosset
Copy link

sebastien-rosset commented Jan 23, 2023

What are you trying to achieve?

Improve the code comments for the metric name in the protobuf spec.

What did you expect to see?

I was expecting the meaning of the DNS name prefix to be explained in the protobuf spec or in the OpenTelemetry specification.

In the protobuf spec, the name of a Metric is documented as:

name of the metric, including its DNS name prefix. It must be unique.

However, I couldn't find the meaning of DNS name prefix, either in the protobuf spec or in the OpenTelemetry specification. If it's referring to the Internet DNS (RFC 1034) or maybe overloading the word "DNS" to mean the hierarchical naming guidelines for metrics.

Additional context.

@sebastien-rosset sebastien-rosset changed the title Clarify meaning of *DNS name prefix* in metric name Clarify meaning of *DNS name prefix* in protobuf code comment for metric name Jan 23, 2023
@SergeyKanzhelev SergeyKanzhelev removed their assignment Feb 18, 2023
@tigrannajaryan tigrannajaryan transferred this issue from open-telemetry/opentelemetry-specification Nov 1, 2023
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Nov 1, 2023
The comment was incorrect and misleading.

Fixes open-telemetry#511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants