Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast in concurrentbatchprocessor if request size > in_flight_limit. #124

Closed
jmacd opened this issue Dec 18, 2023 · 0 comments · Fixed by #126
Closed

Fail fast in concurrentbatchprocessor if request size > in_flight_limit. #124

jmacd opened this issue Dec 18, 2023 · 0 comments · Fixed by #126

Comments

@jmacd
Copy link
Contributor

jmacd commented Dec 18, 2023

The semaphore implementation that we use has a special case for this, but it blocks until the context times out. https://cs.opensource.google/go/x/sync/+/refs/tags/v0.5.0:semaphore/semaphore.go;l=40

This is as-documented, but blocking for timeout will not indicate the error we want to indicate. If the request is too large, let's let it fail fast so the error handler can print something useful.
@jmacd jmacd mentioned this issue Dec 20, 2023
Merged
jmacd added a commit that referenced this issue Dec 20, 2023
@jmacd
(concurrentbatchprocessor) Fail fast when size limit is exceeded (#126)
14a4666 
Fixes #124 
Unrelated cleanups:
- rename max_in_flight_bytes_mib to max_in_flight_size_mib ("bytes" is
redundant), since it's unreleased
- add a brief README.md
- remove an accidental profile output named `out`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(concurrentbatchprocessor) Fail fast when size limit is exceeded jmacd/otel-arrow
1 participant
@jmacd