Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(concurrentbatchprocessor) Fail fast when size limit is exceeded #126

Merged
merged 1 commit into from
Dec 20, 2023
Merged

(concurrentbatchprocessor) Fail fast when size limit is exceeded #126

merged 1 commit into from
Dec 20, 2023

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Dec 20, 2023 •
edited
Loading

Fixes #124
Unrelated cleanups:

  • rename max_in_flight_bytes_mib to max_in_flight_size_mib ("bytes" is redundant), since it's unreleased
  • add a brief README.md
  • remove an accidental profile output named out.

@jmacd jmacd changed the title Fail fast when size limit is exceeded (concurrentbatchprocessor) Fail fast when size limit is exceeded Dec 20, 2023
moh-osman3
moh-osman3 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@moh-osman3 moh-osman3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd merged commit 14a4666 into open-telemetry:main Dec 20, 2023
2 checks passed
@jmacd jmacd deleted the jmacd/failfast_sizelimit branch December 20, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moh-osman3 moh-osman3 moh-osman3 approved these changes

@lquerel lquerel Awaiting requested review from lquerel lquerel is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail fast in concurrentbatchprocessor if request size > in_flight_limit.
2 participants
@jmacd @moh-osman3