-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user from another country I want to see names in a format that we use so that they reflect my cultural norms #6830
As a user from another country I want to see names in a format that we use so that they reflect my cultural norms #6830
Comments
Decision needs to be made if name configuration is decoupled from the rest of registration form configuration. |
@euanmillar ticket updated. Can be unblocked and moved to Ready to build |
Updated task description to include configurable name formatting elsewhere in the app as Burkina Faso needs this |
@rikukissa if we are doing this: "Ensure possible NIDs are removed from user-mgnt.users collection" wont we need a database migration? I wonder if it is worth the effort. It might be acceptable to just leave the national id prop in the database than maintain the migration file. Just an idea |
Good point, I'll update the task description. Long-term it's best if we aim to always have the database and data integrity in tip-top shape, so definitely worth writing a migration |
we often receive requests from countries to have the surname first in this form, we have decided to satisfy that requirement by putting surname first for ALL countries. #6830
A request came for the clients to change the labels for "First name(s)" to "User's first name". Also change "Last name" to "User's surname" for clarity and less confussion. #6830
A request came for the clients to change the labels for "First name(s)" to "User's first name". Also change "Last name" to "User's surname" for clarity and less confussion. opencrvs/opencrvs-core#6830
A request came for the clients to change the labels for "First name(s)" to "User's first name". Also change "Last name" to "User's surname" for clarity and less confussion. opencrvs/opencrvs-core#6830
Remove the question that asks the user for a national ID number in this form as it is not required #6830
Remove the question that asks the user for a national ID number in the User details form as it is not required opencrvs/opencrvs-core#6830
Remove the question that asks the user for a national ID number in this form as it is not required #6830
We no longer need the suffixes for the FamilyName field since we not really using it anywhere #6830
A requirement from client to remove the NID field since most of the contries are not really using it. #6830
We no longer need the suffixes for the FamilyName field since we not really using it anywhere opencrvs/opencrvs-core#6830
Replace older logic to get the name which was based on an assumption that we support names in multiple languages #6830
We've found cleaner way to make the rendered name customizable for each country through client copy from country-config #6830
We need to update all the places where a citizen's name is being referenced to show it in the format that the country chooses #6830
The expected name should match the format for the given country. #6830
To allow countries to have custom ordering for full names #6830
To ensure that we get the format from the country-config #6830
To make the name more usable we had to extract the name formatting logic into it's own function. #6830
Replace older logic to get the name which was based on an assumption that we support names in multiple languages #6830
We've found cleaner way to make the rendered name customizable for each country through client copy from country-config #6830
We need to update all the places where a citizen's name is being referenced to show it in the format that the country chooses #6830
The expected name should match the format for the given country. #6830
…name format (#7957) * Add humanName to constants.ts To allow countries to have custom ordering for full names #6830 * Use constants.humanName on the UserList.tsx comp To ensure that we get the format from the country-config #6830 * Create a utility function getLocalisedname() To make the name more usable we had to extract the name formatting logic into it's own function. #6830 * Use getLocalisedName on the UserList component #6830 * Use getLocalisedName on the UserAudit comp Replace older logic to get the name which was based on an assumption that we support names in multiple languages #6830 * refactor: use getLocalisedName() @ InProgress.tsx We've found cleaner way to make the rendered name customizable for each country through client copy from country-config #6830 * Refactor the work queues to use getLocalisedName() We need to update all the places where a citizen's name is being referenced to show it in the format that the country chooses #6830 * Record changes in the CHANGELOG for this PR #6830 * Use humanName for other search/transformer.ts #6830 * Fix type error 4 the findSavedReference() * Fix faling unit test after using humanName The expected name should match the format for the given country. #6830 * Add the correct local for intlBangla #6830 * Pass intl object for myDrafts transformDraftContent #6830
…name format (#7957) * Add humanName to constants.ts To allow countries to have custom ordering for full names #6830 * Use constants.humanName on the UserList.tsx comp To ensure that we get the format from the country-config #6830 * Create a utility function getLocalisedname() To make the name more usable we had to extract the name formatting logic into it's own function. #6830 * Use getLocalisedName on the UserList component #6830 * Use getLocalisedName on the UserAudit comp Replace older logic to get the name which was based on an assumption that we support names in multiple languages #6830 * refactor: use getLocalisedName() @ InProgress.tsx We've found cleaner way to make the rendered name customizable for each country through client copy from country-config #6830 * Refactor the work queues to use getLocalisedName() We need to update all the places where a citizen's name is being referenced to show it in the format that the country chooses #6830 * Record changes in the CHANGELOG for this PR #6830 * Use humanName for other search/transformer.ts #6830 * Fix type error 4 the findSavedReference() * Fix faling unit test after using humanName The expected name should match the format for the given country. #6830 * Add the correct local for intlBangla #6830 * Pass intl object for myDrafts transformDraftContent #6830
Description
OpenCRVS is hardcoded to display names with family name appearing last in many places: {firstName} {middleName} {lastName}.
But in many countries surname appears first so this should be configurable in record audit and other places for example.
This ticket describes 2 changes that we need to make.
Tech tasks
National System Admin – Create user form
We also want to remove the question that asks the user for a national ID number in this form as it is not required.
user-mgnt.users
collection. Write a migration to remove the field from existing users.How citizen data appears in the team user list, work queues and record audit
constants.humanName
with a default value{firstName} {lastName}
, then the client could read this content key and dynamically choose to represent names in work queues and record audit according to it. If the content key was like this:{lastName} {middleName} {firstName}
then the names could be rendered appropriatelyconstants.humanName
with a default value{firstName} {lastName}
and start using it in the admin view's user listing. Keep in mind that this same constant is to be used for rendering record subject names so for instance a country might want to have this as{lastName} {middleName} {firstName}
generateName
in packages/client/src/utils/data-formatting.ts so that it respects the name format defined in the team user list viewOther applications
Go through the app and test for instance
{lastName} {middleName} {firstName}
properly applies everywhere such as work-queues and record audit.In release notes: Add a few examples of different ways to configure this e.g. middle name doesn't exist OR
The text was updated successfully, but these errors were encountered: