feat: Add constants.humanName to allow countries to have custom full name format #7957

Siyasanga · 2024-11-12T09:17:04Z

In order to allow countries to define their own full name format, we are adding a constants.humanName into the client.csv translations, which will then be used everywhere where we are displaying system users and citizen's name in the systems.

Addresses #6830

Countryconfig: opencrvs/opencrvs-countryconfig#314
Farajaland: opencrvs/opencrvs-farajaland#1164

ocrvs-bot · 2024-11-14T08:44:25Z

Your environment is deployed to https://ocrvs-6830-human-name-constant.opencrvs.dev

Zangetsu101

@Siyasanga After taking a look at the changes made to the e2e tests, I would say it's better to change all those places in core to use the new format instead. As if only some of the places use the new format, then it would just create confusion

Siyasanga · 2025-01-15T07:53:22Z

Hi @Zangetsu101, hope you're good. Please review this PR when you have a chance.

I have reverted the changes that were trying to generate the full name for the form field in the review screens as we had discussed. I also removed the assertions that were trying to prove that the name is customisable via the config. We'll only depend on the unit tests for now untill we get a country that uses full name that is different to farajahland.

I've also removed the changes on the integration tests for the Farajahland repo.

Zangetsu101 · 2025-01-21T13:06:35Z

packages/client/src/utils/draftUtils.test.ts

+const intlBangla = createIntl(
+  {
+    locale: 'en',
+    messages: {}
+  },
+  cache
+)


Is this supposed to be like so?

Nice catch, thanks Tameem. Fixed

#6830

Replace older logic to get the name which was based on an assumption that we support names in multiple languages #6830

We've found cleaner way to make the rendered name customizable for each country through client copy from country-config #6830

We need to update all the places where a citizen's name is being referenced to show it in the format that the country chooses #6830

#6830

The expected name should match the format for the given country. #6830

#6830

euanmillar · 2025-01-24T14:22:01Z

@Zangetsu101 @Siyasanga and I dont know why knip is failing here but tests are all passing and think this is ready to merge?

Zangetsu101 · 2025-01-27T06:04:57Z

@Siyasanga What's the status of e2e tests? As long as they are passing, we can merge this in

Siyasanga · 2025-01-27T10:01:17Z

@Siyasanga What's the status of e2e tests? As long as they are passing, we can merge this in

They are passing so I will merge this and the related contry-config PR

Zangetsu101 · 2025-01-27T13:08:30Z

CHANGELOG.md

@@ -29,6 +29,8 @@
 - A new GraphQL mutation `upsertRegistrationIdentifier` is added to allow updating the patient identifiers of a registration record such as NID [#8034](https://github.com/opencrvs/opencrvs-core/pull/8034)
 - A new GraphQL mutation `updateField` is added to allow updating any field in a record [#8291](https://github.com/opencrvs/opencrvs-core/pull/8291)
 - Updated GraphQL mutation `confirmRegistration` to allow adding a `comment` for record audit [#8197](https://github.com/opencrvs/opencrvs-core/pull/8197)
+- Introduced a new customisable UI component: Banner [#8276](https://github.com/opencrvs/opencrvs-core/issues/8276)


Suggested change

- Introduced a new customisable UI component: Banner [#8276](https://github.com/opencrvs/opencrvs-core/issues/8276)

Seems to be something irrelevant

…name format (#7957) * Add humanName to constants.ts To allow countries to have custom ordering for full names #6830 * Use constants.humanName on the UserList.tsx comp To ensure that we get the format from the country-config #6830 * Create a utility function getLocalisedname() To make the name more usable we had to extract the name formatting logic into it's own function. #6830 * Use getLocalisedName on the UserList component #6830 * Use getLocalisedName on the UserAudit comp Replace older logic to get the name which was based on an assumption that we support names in multiple languages #6830 * refactor: use getLocalisedName() @ InProgress.tsx We've found cleaner way to make the rendered name customizable for each country through client copy from country-config #6830 * Refactor the work queues to use getLocalisedName() We need to update all the places where a citizen's name is being referenced to show it in the format that the country chooses #6830 * Record changes in the CHANGELOG for this PR #6830 * Use humanName for other search/transformer.ts #6830 * Fix type error 4 the findSavedReference() * Fix faling unit test after using humanName The expected name should match the format for the given country. #6830 * Add the correct local for intlBangla #6830 * Pass intl object for myDrafts transformDraftContent #6830

Siyasanga force-pushed the ocrvs-6830-human-name-constant branch from 1a13fc2 to b66f929 Compare November 14, 2024 08:32

Siyasanga added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Nov 14, 2024

github-actions bot temporarily deployed to ocrvs-6830-human-name-constant November 14, 2024 08:36 Inactive

Siyasanga marked this pull request as ready for review November 14, 2024 08:42

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant November 14, 2024 08:46 — with GitHub Actions Inactive

Siyasanga self-assigned this Nov 14, 2024

Siyasanga added this to the v1.7.0 milestone Nov 14, 2024

Siyasanga force-pushed the ocrvs-6830-human-name-constant branch from b66f929 to 948771b Compare November 14, 2024 09:55

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant November 14, 2024 09:55 — with GitHub Actions Inactive

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant November 14, 2024 11:32 — with GitHub Actions Inactive

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant November 14, 2024 23:34 — with GitHub Actions Inactive

Siyasanga linked an issue Nov 15, 2024 that may be closed by this pull request

As a user from another country I want to see names in a format that we use so that they reflect my cultural norms #6830

Closed

6 tasks

Zangetsu101 requested changes Nov 22, 2024

View reviewed changes

Zangetsu101 added 🔧Waiting for fixes and removed 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it labels Nov 22, 2024

Siyasanga force-pushed the ocrvs-6830-human-name-constant branch from a2148db to c6f8c7a Compare December 18, 2024 22:30

Siyasanga force-pushed the ocrvs-6830-human-name-constant branch 4 times, most recently from 40966ab to fc69672 Compare January 15, 2025 07:38

Siyasanga added 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it and removed 🔧Waiting for fixes labels Jan 15, 2025

github-actions bot temporarily deployed to ocrvs-6830-human-name-constant January 15, 2025 07:48 Inactive

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant January 15, 2025 07:54 — with GitHub Actions Inactive

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant January 16, 2025 06:51 — with GitHub Actions Inactive

Siyasanga added the 💅 Waiting For Review label Jan 16, 2025

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant January 17, 2025 06:16 — with GitHub Actions Inactive

Zangetsu101 reviewed Jan 21, 2025

View reviewed changes

Siyasanga added 9 commits January 24, 2025 10:35

Use getLocalisedName on the UserList component

9cbaf3c

#6830

Use getLocalisedName on the UserAudit comp

3fd97a5

Replace older logic to get the name which was based on an assumption that we support names in multiple languages #6830

refactor: use getLocalisedName() @ InProgress.tsx

4e881c8

We've found cleaner way to make the rendered name customizable for each country through client copy from country-config #6830

Refactor the work queues to use getLocalisedName()

d55b3cf

We need to update all the places where a citizen's name is being referenced to show it in the format that the country chooses #6830

Record changes in the CHANGELOG for this PR

4084f18

#6830

Use humanName for other search/transformer.ts

ac48fbd

#6830

Fix type error 4 the findSavedReference()

4a730a8

Fix faling unit test after using humanName

54f52c2

The expected name should match the format for the given country. #6830

Add the correct local for intlBangla

8cf8cc0

#6830

Siyasanga force-pushed the ocrvs-6830-human-name-constant branch from 5e12e50 to 8cf8cc0 Compare January 24, 2025 08:53

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant January 24, 2025 08:54 — with GitHub Actions Inactive

Pass intl object for myDrafts transformDraftContent

52a39ab

#6830

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant January 24, 2025 13:55 — with GitHub Actions Inactive

euanmillar approved these changes Jan 24, 2025

View reviewed changes

euanmillar requested a review from Zangetsu101 January 24, 2025 14:22

Siyasanga temporarily deployed to ocrvs-6830-human-name-constant January 27, 2025 06:25 — with GitHub Actions Inactive

Merge branch 'develop' into ocrvs-6830-human-name-constant

9a9cb33

Siyasanga deployed to ocrvs-6830-human-name-constant January 27, 2025 10:00 — with GitHub Actions Active

Siyasanga enabled auto-merge January 27, 2025 10:01

Siyasanga disabled auto-merge January 27, 2025 10:02

Siyasanga enabled auto-merge (squash) January 27, 2025 10:02

Zangetsu101 approved these changes Jan 27, 2025

View reviewed changes

Siyasanga merged commit 677c7b3 into develop Jan 27, 2025
73 checks passed

Zangetsu101 deleted the ocrvs-6830-human-name-constant branch January 27, 2025 13:09

github-actions bot pushed a commit that referenced this pull request Jan 27, 2025

Placeholder commit for PR #7957

c4e7b25

github-actions bot pushed a commit that referenced this pull request Jan 27, 2025

Placeholder commit for PR #7957

029bcb9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add constants.humanName to allow countries to have custom full name format #7957

feat: Add constants.humanName to allow countries to have custom full name format #7957

Siyasanga commented Nov 12, 2024 •

edited by euanmillar

Loading

ocrvs-bot commented Nov 14, 2024

Zangetsu101 left a comment

Siyasanga commented Jan 15, 2025

Zangetsu101 Jan 21, 2025

Siyasanga Jan 22, 2025

euanmillar commented Jan 24, 2025

Zangetsu101 commented Jan 27, 2025

Siyasanga commented Jan 27, 2025

Zangetsu101 Jan 27, 2025

Zangetsu101 Jan 27, 2025

feat: Add constants.humanName to allow countries to have custom full name format #7957

feat: Add constants.humanName to allow countries to have custom full name format #7957

Conversation

Siyasanga commented Nov 12, 2024 • edited by euanmillar Loading

ocrvs-bot commented Nov 14, 2024

Zangetsu101 left a comment

Choose a reason for hiding this comment

Siyasanga commented Jan 15, 2025

Zangetsu101 Jan 21, 2025

Choose a reason for hiding this comment

Siyasanga Jan 22, 2025

Choose a reason for hiding this comment

euanmillar commented Jan 24, 2025

Zangetsu101 commented Jan 27, 2025

Siyasanga commented Jan 27, 2025

Zangetsu101 Jan 27, 2025

Choose a reason for hiding this comment

Zangetsu101 Jan 27, 2025

Choose a reason for hiding this comment

Siyasanga commented Nov 12, 2024 •

edited by euanmillar

Loading