-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace swagger to drf_yasg #226
Replace swagger to drf_yasg #226
Conversation
Thanks for the pull request, @NeOneSoft! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @natabene!! I created this PR to solve the python 3.8 dependencies conflicts since I had been experiencing similar issues in another repositories so I would like to ask for the last review here and once it's merged we could closed the original. Thank you so much for your support!! |
@NeOneSoft Thank you for your contribution! |
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 412 412
Branches 64 64
=========================================
Hits 412 412
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Looks like this one is missing the dependency change from #176. Would it make more sense to go back to the original PR, remove the .txt requirements changes, rebase, and then re-compile requirements? |
feat: add drf_yasg module feat: remove drf_yasg from test settings feat: solve conflicted dependencies feat: add missing module feat: solve conflicted files feat: solve conflicts on doc.txt feat: solve conflicts on doc.txt depends feat: solve conflicts on doc.txt manually
84382bb
to
aced8dc
Compare
Hi @timmc-edx, thank you so much for your support!!. What you suggest makes sense for me!! I only continue using this PR to test if the changes on the dependencies works since it was a little bit confusing for me. In fact I believe that now this is ready !! |
@NeOneSoft 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR was created on behalf of PR to solve some conflicts regarding python 3.8 dependencies.