Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace swagger to drf_yasg #226

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

NeOneSoft
Copy link
Contributor

@NeOneSoft NeOneSoft commented Jul 22, 2022

Description

This PR was created on behalf of PR to solve some conflicts regarding python 3.8 dependencies.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 22, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @NeOneSoft! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@NeOneSoft
Copy link
Contributor Author

Hi @natabene!! I created this PR to solve the python 3.8 dependencies conflicts since I had been experiencing similar issues in another repositories so I would like to ask for the last review here and once it's merged we could closed the original. Thank you so much for your support!!

@natabene
Copy link

@NeOneSoft Thank you for your contribution!

@timmc-edx timmc-edx self-assigned this Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #226 (ce383c5) into master (ffe1d92) will not change coverage.
The diff coverage is n/a.

❗ Current head ce383c5 differs from pull request most recent head aced8dc. Consider uploading reports for the commit aced8dc to get more accurate results

@@            Coverage Diff            @@
##            master      #226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          412       412           
  Branches        64        64           
=========================================
  Hits           412       412           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe1d92...aced8dc. Read the comment docs.

@timmc-edx
Copy link
Contributor

Looks like this one is missing the dependency change from #176. Would it make more sense to go back to the original PR, remove the .txt requirements changes, rebase, and then re-compile requirements?

feat: add drf_yasg module

feat: remove drf_yasg from test settings

feat: solve conflicted dependencies

feat: add missing module

feat: solve conflicted files

feat: solve conflicts on doc.txt

feat: solve conflicts on doc.txt depends

feat: solve conflicts on doc.txt manually
@NeOneSoft NeOneSoft force-pushed the edunext/edx_upgrade_swagger_v02 branch from 84382bb to aced8dc Compare August 2, 2022 17:18
@NeOneSoft
Copy link
Contributor Author

NeOneSoft commented Aug 2, 2022

Hi @timmc-edx, thank you so much for your support!!. What you suggest makes sense for me!! I only continue using this PR to test if the changes on the dependencies works since it was a little bit confusing for me. In fact I believe that now this is ready !!

@timmc-edx timmc-edx merged commit 580a33f into openedx:master Aug 3, 2022
@openedx-webhooks
Copy link

@NeOneSoft 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants