-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert to single-value video gallery dropdown filter #414
fix: revert to single-value video gallery dropdown filter #414
Conversation
Thanks for the pull request, @CefBoud! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@@ -11,7 +11,7 @@ const MultiSelectFilterDropdown = ({ | |||
}) => { | |||
const intl = useIntl(); | |||
return ( | |||
<Dropdown autoClose={false}> | |||
<Dropdown autoClose="outside"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we convert this into a prop and pass it from the component?
32222e5
to
087edf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ✅ I tested this on the devstack.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository.
@CefBoud can you remove the draft status please. |
087edf0
to
1710520
Compare
…ngle-value video filter
1710520
to
b3e3620
Compare
@farhaanbukhsh Description fixed and status changed. |
@navinkarkera Another request to add the "jira:2u" label. :) cc: @cablaa77 |
@tecoholic is this blended work? |
Hi @openedx/teaching-and-learning! This is ready for review. Thanks! |
I've created issue TNL-11222 in the private 2U Jira. |
@e0d Yes. This is related to the Video Block UX improvements project work. |
@CefBoud 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR affects the
SelectionModal
component used byVideoGallery
andSelectImageModal
components.It reverts changes added by #368. The goal is to have a uniform filter & sort UI.
Before
After
Testing instructions
Enable the new video editor (create waffle flags
new_core_editors.use_new_video_editor
andnew_core_editors.use_video_gallery_flow
for everyone)Create a course unit with a video
Open the video gallery http://localhost:2001/course/course-v1:edX+DemoX+Demo_Course/editor/course-videos/videoBlockId
Filter by status using the single-value filter dropdown.
private ref: BB-8054