fix: video status badge translation

[CefBoud]

This PR is related to:

• fix: disable video status translation for JSON endpoint edx-platform#33939

The changes are minimal:

• TODO Comments are removed.
• The usage of the status field is replaced by the new status_nontranslated field (introduced in the PR above).
• The display of a video's status in the status badge is done through FormattedMessage instead of a plain render to handle translation within React.

[openedx-webhooks]

Thanks for the pull request, @CefBoud! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (dedcb14) to head (2f8e96c).
Report is 1 commits behind head on main.

❗ Current head 2f8e96c differs from pull request most recent head 3006641. Consider uploading reports for the commit 3006641 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   89.25%   90.58%   +1.32%     
==========================================
  Files         246      227      -19     
  Lines        4475     4130     -345     
  Branches      917      831      -86     
==========================================
- Hits         3994     3741     -253     
+ Misses        454      369      -85     
+ Partials       27       20       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mphilbrick211]

Hi @openedx/teaching-and-learning! This is ready for review. Thanks!

[openedx-webhooks]

I've created issue TNL-11332 in the private 2U Jira.

[tecoholic]

@CefBoud 👍 Just left a small nit and a question.

• I tested this: Used the instructions from fix: revert to single-value video gallery dropdown filter #414 and fix: disable video status translation for JSON endpoint edx-platform#33939 to verify that the filtering of videos works when the user's language is not English.
• I read through the code
• I checked for accessibility issues
• Includes documentation

[tecoholic]

Nit:

Suggested change

	description: 'label for video status (any status)',
	description: 'Label for video status (any status)',

[tecoholic]

I like that it is a bit more generic now 👍, as it can be reused in other places. However, I still see it only being used in filterMessages. So, I am curious about the motivation behind this change.

[CefBoud]

It is used in the status badge display.

[tecoholic]

Ah! Cool. :)

[mphilbrick211]

Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? If so, we can work on the branch conflicts. Thanks!

[mphilbrick211]

Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? If so, we can work on the branch conflicts. Thanks!

Friendly ping on this, @openedx/2u-tnl!

[farhaanbukhsh]

@mphilbrick211 any updates here?

[mphilbrick211]

@mphilbrick211 any updates here?

Hi @openedx/2u-tnl - is someone able to review this please? Thanks!

[KristinAoki]

@CefBoud conflicts need to be resolved before this can be merged

[CefBoud]

@KristinAoki Thanks for the review. Fixed.

[openedx-webhooks]

@CefBoud 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.