Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom nonce in OIDAuthorizationRequest #788

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Sep 20, 2023

this PR is in response to this PR which has been opened ~ year ago and appears to be in a limbo

google/GoogleSignIn-iOS#244

The PR did get a review from @mdmathias who pointed out one issue here that seems to prevent the PR from getting merged.

There is a substantial community interest to get the PR merged and it appears there is willingness on the google side as well.

I'm attempting to unblock the PR by adding the initializer that is being asked for in the review comment (linked above).

Thank you in advance for your review

@vonovak
Copy link
Contributor Author

vonovak commented Sep 20, 2023

edit: I'm listed here so I believe the agreement signing part is done

I signed the contributor agreement. According to https://github.com/openid/AppAuth-iOS/blob/master/CONTRIBUTING.md there's two to sign, but I only really saw one.

Hope somebody's going to review this :D

@vonovak vonovak changed the title feat: allow custom nonce in OIDAuthorizationReques feat: allow custom nonce in OIDAuthorizationRequest Sep 20, 2023
Source/AppAuthCore/OIDAuthorizationRequest.h Show resolved Hide resolved
Source/AppAuthCore/OIDAuthorizationRequest.m Outdated Show resolved Hide resolved
UnitTests/OIDAuthorizationRequestTests.m Outdated Show resolved Hide resolved
@vonovak vonovak requested a review from mdmathias October 4, 2023 19:07
@mdmathias
Copy link
Collaborator

@vonovak I will be OOO for about 1.5 weeks starting tomorrow. I promise to take a look when I am back. Thanks!

Copy link
Collaborator

@mdmathias mdmathias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! Just one last suggestion to make an assert more clear. Ready to go after this.

UnitTests/OIDAuthorizationRequestTests.m Outdated Show resolved Hide resolved
@mdmathias mdmathias merged commit 8b437c4 into openid:master Oct 18, 2023
10 checks passed
@vonovak vonovak deleted the feat/custom-nonce branch October 18, 2023 19:31
@vonovak
Copy link
Contributor Author

vonovak commented Oct 18, 2023

thanks for review and merge! 🙂

@mdmathias
Copy link
Collaborator

Absolutely, thanks for the contribution. :D

HadesPTIT pushed a commit to HadesPTIT/AppAuth-iOS that referenced this pull request Nov 14, 2023
@vonovak
Copy link
Contributor Author

vonovak commented Dec 19, 2023

@mdmathias would you please share an ETA for the next release? I'd like to integrate this change into https://github.com/google/GoogleSignIn-iOS

thank you

@mdmathias
Copy link
Collaborator

We are currently working on adding a privacy manifest for this library, and the next release will be out before Spring 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants