-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom nonce in OIDAuthorizationRequest #788
Conversation
edit: I'm listed here so I believe the agreement signing part is done I signed the contributor agreement. According to https://github.com/openid/AppAuth-iOS/blob/master/CONTRIBUTING.md there's two to sign, but I only really saw one. Hope somebody's going to review this :D |
@vonovak I will be OOO for about 1.5 weeks starting tomorrow. I promise to take a look when I am back. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! Just one last suggestion to make an assert more clear. Ready to go after this.
thanks for review and merge! 🙂 |
Absolutely, thanks for the contribution. :D |
…)" This reverts commit 8b437c4.
@mdmathias would you please share an ETA for the next release? I'd like to integrate this change into https://github.com/google/GoogleSignIn-iOS thank you |
We are currently working on adding a privacy manifest for this library, and the next release will be out before Spring 2024. |
this PR is in response to this PR which has been opened ~ year ago and appears to be in a limbo
google/GoogleSignIn-iOS#244
The PR did get a review from @mdmathias who pointed out one issue here that seems to prevent the PR from getting merged.
There is a substantial community interest to get the PR merged and it appears there is willingness on the google side as well.
I'm attempting to unblock the PR by adding the initializer that is being asked for in the review comment (linked above).
Thank you in advance for your review