Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage 6 #2659

Merged
merged 10 commits into from
Aug 13, 2024
Merged

Increase code coverage 6 #2659

merged 10 commits into from
Aug 13, 2024

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Aug 7, 2024 •
edited by jira bot
Loading

DISCO-448
This gets to 100% coverage for all TS source files. Sorry it's such a big PR.

@RoyEJohnson RoyEJohnson requested a review from jivey August 7, 2024 20:55
jivey
jivey approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with a lot of this, but as it almost exclusively adds types and tests without changing functionality, things seem good.

src/app/pages/details/common/links-to-translations.tsx Outdated Show resolved Hide resolved
test/src/pages/details/book-details-context.js Outdated Show resolved Hide resolved
@RoyEJohnson RoyEJohnson force-pushed the increase-code-coverage-6 branch from be6bbca to 86fa6f7 Compare August 12, 2024 22:40
@RoyEJohnson RoyEJohnson merged commit edcb242 into main Aug 13, 2024
1 check passed
@RoyEJohnson RoyEJohnson deleted the increase-code-coverage-6 branch August 13, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jivey jivey jivey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyEJohnson @jivey