Port details page to ts, part 1 #2679
Conversation
RoyEJohnson
force-pushed
the
port-details-page-to-ts
branch
2 times, most recently
from
6f78ff3 to
3fa5103
Compare
|
|
||
| function FormWithAfterSubmit({ | ||
| afterSubmit, | ||
| responseId = 'form-response', | ||
| children, | ||
| onSubmit: firstOnSubmit, |
There was a problem hiding this comment.
This parameter was not used.
| @@ -18,55 +24,45 @@ function Header({entry}) { | |||
| ); | |||
| } | |||
|
|
|||
| function PhoneBox({entry, closeAfterDelay}) { | |||
There was a problem hiding this comment.
It wasn't called with closeAfterDelay
| ))} | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| function Button({href, text, buttonClass, onClick}) { |
There was a problem hiding this comment.
Wasn't being called with onClick
| ); | ||
| } | ||
|
|
||
| describe('details/recommended-callout', () => { |
There was a problem hiding this comment.
Wrapped the tests in describe, which made it a major change (due to indenting everything)
| Variant: (p: any) => React.JSX.Element, // eslint-disable-line @typescript-eslint/no-explicit-any | ||
| p: object | ||
| ] { | ||
| const {id, variant} = variantParams; |
There was a problem hiding this comment.
Do we want to use a rest object for the variantParams to prevent id and variant being sent to the components?
There was a problem hiding this comment.
All of the components use id and two of them use variant. There's likely a better way to do the repetition-elimination I was doing here, but it hasn't become clear to me yet.
| id?: string; | ||
| variant?: string; | ||
| }): [ | ||
| Variant: (p: any) => React.JSX.Element, // eslint-disable-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
I wonder if a union type that uses ComponentProps would work here but it may not be worth the hassle
There was a problem hiding this comment.
I fiddled with it, but couldn't make it happy.
RoyEJohnson
force-pushed
the
port-details-page-to-ts
branch
2 times, most recently
from
6022016 to
77051ac
Compare
[CORE-538]
Again, it's almost all adding/fixing types and tests.
pretttierdid some swapping of double quotes for single quotes and changed line wrapping.[CORE-538]: https://openstax.atlassian.net/browse/CORE-538?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ