Port details page to ts 2 #2680
Conversation
RoyEJohnson
force-pushed
the
port-details-page-to-ts-2
branch
2 times, most recently
from
30cca47 to
6ae7c3e
Compare
| @@ -5,11 +5,9 @@ import memoize from 'lodash/memoize'; | |||
| export function bookToc(slug: string) { | |||
| return cmsFetch(slug) | |||
| .then((bi) => { | |||
| const isRex = true; | |||
There was a problem hiding this comment.
All books are Rex now, so I removed the CNX fetching stuff.
| } | ||
|
|
||
| export default function AuthorsSection() { | ||
| const {authors, title} = useDetailsContext(); |
There was a problem hiding this comment.
had been passing model around, but it's just the info from the Context. polish is derived from it.
| const title = model.title; | ||
| const blurb = model.errataContent; | ||
| export function ErrataContents() { | ||
| const {title, errataContent: blurb, bookState} = useDetailsContext(); |
There was a problem hiding this comment.
Again, model and polish didn't need to be parameters.
|
|
||
| type LeftContentModelType = { |
There was a problem hiding this comment.
This was a different definition of what should have been ResourceModel
|
|
||
| const settings = window.SETTINGS; | ||
|
|
||
| export default function ResourceBox({model}) { |
There was a problem hiding this comment.
I split the components out into resource-box.tsx, and left the utilities in here, renaming it resource-box-utils.js It will go to TS in the next PR.
| @@ -16,12 +17,10 @@ type VideoResourceBoxModelType = { | |||
| resourceCategory: string; | |||
| }; | |||
|
|
|||
| type BoxModel = { heading: string }; | |||
There was a problem hiding this comment.
Another that should have just been ResourceModel
| onClick={() => toggle()} | ||
| onKeyDown={treatSpaceOrEnterAsClick} | ||
| aria-controls="toc-drawer" |
There was a problem hiding this comment.
A little accessibility
| {viewsUsed.desktop && <JITLoad importFn={importDesktopView} />} | ||
| </div> | ||
| { | ||
| viewsUsed.phone && |
There was a problem hiding this comment.
Moved the condition to the outside to control the entire view.
RoyEJohnson
force-pushed
the
port-details-page-to-ts-2
branch
from
a0c23a1 to
a72bef4
Compare
CORE-592
This builds on #2679 which should be merged first.