Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade to react 18 #2404

Closed
wants to merge 11 commits into from
Closed

refactor: upgrade to react 18 #2404

wants to merge 11 commits into from

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Mar 14, 2023

Types

  • 🪚 Refactors

Background or solution

Changelog

@Ricbet Ricbet self-assigned this Mar 14, 2023
@github-actions github-actions bot added the ⚙️ refactor Refactor code label Mar 14, 2023
@github-actions
Copy link
Contributor

ChatGPT Code Review:

CodeReview Feedback:

  1. It's good to see that you are upgrading to React 18, which is a significant release. However, it's not clear from the commit message what other changes are included in the commit apart from just the upgrade. It's recommended to provide a more descriptive commit message that covers all the changes made in the commit.

  2. The commit message doesn't follow the Angular commit message format. The format requires a mandatory type, an optional scope, and a subject line, followed by a detailed description. For example, the commit message can be formatted as "feat(Component): add new prop to enable/disable feature" or "fix(Styles): correct the font size in the header section". This standardized format helps to quickly understand the nature of the changes made in the commit.

  3. The diff file is missing, which makes it difficult to provide more detailed feedback on the code changes. Please provide the diff file so that we can review it and provide suggestions for improvement.

Suggested commit message:
feat: Upgrade React to version 18
This commit includes an upgrade to React version 18 and refactorings to better handle new APIs and features. Detailed changes: [insert detailed changes/updates here]

@Ricbet Ricbet linked an issue Mar 14, 2023 that may be closed by this pull request
@Ricbet Ricbet force-pushed the refactor/upgrade-react-18 branch from f73af63 to 693c37b Compare March 16, 2023 09:22
@Ricbet Ricbet force-pushed the refactor/upgrade-react-18 branch 2 times, most recently from c85e183 to 6b83d19 Compare June 8, 2023 02:35
lerna.json Outdated Show resolved Hide resolved
@Ricbet Ricbet changed the title WIP: refactor: upgrade react 18 refactor: upgrade react 18 Jun 8, 2023
@bytemain bytemain changed the title refactor: upgrade react 18 refactor: upgrade to react 18 Jun 8, 2023
@Ricbet Ricbet force-pushed the refactor/upgrade-react-18 branch 3 times, most recently from d4de10a to cf75e08 Compare June 28, 2023 11:57
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -40.83% ⚠️

Comparison is base (52c5679) 57.62% compared to head (4718ac4) 16.79%.

❗ Current head 4718ac4 differs from pull request most recent head 80a8955. Consider uploading reports for the commit 80a8955 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2404       +/-   ##
===========================================
- Coverage   57.62%   16.79%   -40.83%     
===========================================
  Files        1337     1337               
  Lines       84173    84164        -9     
  Branches    17493    17494        +1     
===========================================
- Hits        48507    14139    -34368     
- Misses      32412    63989    +31577     
- Partials     3254     6036     +2782     
Flag Coverage Δ
jsdom ?
node 16.79% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/file-tree-next/src/browser/file-tree.service.ts 0.00% <0.00%> (-70.26%) ⬇️
...xt/src/browser/services/file-tree-model.service.ts 0.00% <0.00%> (-55.02%) ⬇️
...-layout/src/browser/accordion/accordion.service.ts 0.00% <0.00%> (-58.36%) ⬇️
...s/main-layout/src/browser/tabbar/tabbar.service.ts 0.00% <0.00%> (-64.54%) ⬇️
packages/output/src/browser/output.service.ts 0.00% <0.00%> (-67.15%) ⬇️

... and 817 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet force-pushed the refactor/upgrade-react-18 branch 4 times, most recently from cadb3e8 to b52933f Compare July 3, 2023 08:00
@Ricbet Ricbet force-pushed the refactor/upgrade-react-18 branch 2 times, most recently from adab9a8 to de04917 Compare July 12, 2023 07:31
@Ricbet Ricbet force-pushed the refactor/upgrade-react-18 branch from de04917 to a8b762d Compare August 2, 2023 07:55
@Ricbet Ricbet force-pushed the refactor/upgrade-react-18 branch from 4718ac4 to 80a8955 Compare August 10, 2023 05:55
@stale
Copy link

stale bot commented Oct 9, 2023

此问题已被自动标记为已过时,如果没有进一步的活动,它将被关闭。谢谢您的贡献。
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@erha19
Copy link
Member

erha19 commented Nov 16, 2023

#3171 进一步处理。

@erha19 erha19 closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] 升级到 React 18
4 participants