-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade to react 18 #3171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erha19
force-pushed
the
refactor/upgrade-to-react-18-next
branch
from
December 1, 2023 03:57
41cea35
to
22c4547
Compare
Ricbet
previously approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bytemain
reviewed
Dec 6, 2023
bytemain
reviewed
Dec 6, 2023
bytemain
previously approved these changes
Dec 6, 2023
bytemain
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖[deprecated] Generated by Copilot at a7c746e
IS_REACT_ACT_ENVIRONMENT
to indicate a React 18 concurrent mode environment (link)core-browser
package (link, link, link, link)main
andApp
components to invoke thedidRendered
callback from the app config instance when theBoxPanel
component is rendered (link, link, link, link, link)comments-item.view.tsx
file to handle the case when the body is an object with avalue
property (link)select/index.tsx
file to support the new select API that allows grouping and customizing the options and to avoid conflicts with other event listeners (link, link, link)act
function in thecomment.service.test.ts
file (link, link, link, link, link)comment-thread.test.ts
file to use a single comment body instead of multiple ones (link, link, link, link)PropsWithChildren
type to explicitly declare the children prop (link, link, link, link, link, link, link, link, link, link, link)React.SFC
type annotation from the return type of thecreateFromIconfontCN
function in theiconfont-cn.tsx
file (link)--legacy-peer-deps
flag to thelerna.json
file to avoid conflicts with the peer dependencies of React 18 and other packages (link)beforeEach
block, and some empty lines in thecomment.service.test.ts
file (link, link, link, link)SlotDecorator
component in theslot.tsx
file to add thecolor
,children
, andbackgroundColor
props (link)comment.service.test.ts
file (link)ref: #861
Changelog
🤖[deprecated] Generated by Copilot at a7c746e
This pull request updates the codebase to use React 18 and its new features for concurrent mode and client-only rendering. It also improves the type safety, readability, and flexibility of various components and tests. It fixes some issues with the comment and select APIs and removes some deprecated or redundant code. It affects the files
packages/comments/*
,packages/components/*
,packages/core-browser/*
,jest.setup.jsdom.js
,lerna.json
, andpackage.json
.