-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mvtec 3d #907
Mvtec 3d #907
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Ooh sorry, theres still some trash in it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexriedel1! This is something that has been on our list for ages, but never got around to. Overall the PR looks good, but as you already mentioned, there seem to be some leftovers from development/debugging. If you could clean those up and address these other minor comments we'd be happy to add this to the library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR. Just a few more comments, which I missed in my initial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexriedel1, thank you for your patience and for this great PR! Nice and clean code!
I only have few comments.
now its working :)
|
This reverts commit 052a3ad.
Description
Checklist