Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mvtec 3d #907

Merged
merged 36 commits into from
Mar 1, 2023
Merged

Mvtec 3d #907

merged 36 commits into from
Mar 1, 2023

Conversation

alexriedel1
Copy link
Contributor

@alexriedel1 alexriedel1 commented Feb 11, 2023

Description

  • I have added support for the MVTec3D dataset
  • added support for 3D anomaly detection folder datasets

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added Data Docs Notebooks Post-Processing The components that are related to post-processing Setup labels Feb 11, 2023
@alexriedel1
Copy link
Contributor Author

Ooh sorry, theres still some trash in it

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexriedel1! This is something that has been on our list for ages, but never got around to. Overall the PR looks good, but as you already mentioned, there seem to be some leftovers from development/debugging. If you could clean those up and address these other minor comments we'd be happy to add this to the library.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
anomalib/data/base/dataset.py Outdated Show resolved Hide resolved
anomalib/data/folder.py Outdated Show resolved Hide resolved
anomalib/data/mvtec_3d.py Outdated Show resolved Hide resolved
anomalib/data/utils/image.py Show resolved Hide resolved
anomalib/post_processing/visualizer.py Outdated Show resolved Hide resolved
anomalib/data/mvtec_3d.py Show resolved Hide resolved
@github-actions github-actions bot removed the Setup label Feb 15, 2023
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR. Just a few more comments, which I missed in my initial review

anomalib/data/folder_3d.py Outdated Show resolved Hide resolved
anomalib/data/__init__.py Show resolved Hide resolved
@github-actions github-actions bot added the Setup label Feb 26, 2023
@github-actions github-actions bot removed the Setup label Feb 26, 2023
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks again!

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexriedel1, thank you for your patience and for this great PR! Nice and clean code!

I only have few comments.

anomalib/data/folder_3d.py Outdated Show resolved Hide resolved
anomalib/data/folder_3d.py Outdated Show resolved Hide resolved
anomalib/data/folder_3d.py Outdated Show resolved Hide resolved
notebooks/100_datamodules/103_folder.ipynb Outdated Show resolved Hide resolved
@alexriedel1
Copy link
Contributor Author

now its working :)

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
debug statements (python)................................................Passed
detect private key.......................................................Passed
black....................................................................Passed
ruff.....................................................................Passed
mypy.....................................................................Passed
nbqa-black...............................................................Passed
nbqa-ruff................................................................Passed
Lint Dockerfiles.........................................................Passed

@samet-akcay samet-akcay enabled auto-merge (squash) March 1, 2023 20:34
@samet-akcay samet-akcay merged commit 052a3ad into openvinotoolkit:main Mar 1, 2023
samet-akcay added a commit that referenced this pull request Mar 2, 2023
This reverts commit 052a3ad.
@samet-akcay samet-akcay mentioned this pull request Mar 2, 2023
samet-akcay added a commit that referenced this pull request Mar 2, 2023
Revert "Mvtec 3d (#907)"

This reverts commit 052a3ad.
@alexriedel1 alexriedel1 mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Notebooks Post-Processing The components that are related to post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants