Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Mvtec 3d" #941

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Revert "Mvtec 3d" #941

merged 1 commit into from
Mar 2, 2023

Conversation

samet-akcay
Copy link
Contributor

Reverts #907 due to the failed tests.

This reverts commit 052a3ad.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added Data Docs Notebooks Post-Processing The components that are related to post-processing labels Mar 2, 2023
@samet-akcay
Copy link
Contributor Author

@alexriedel1 I've merged your PR, but reverted it now since the tests are failing. Will you be able to check why the tests are failing?

@alexriedel1
Copy link
Contributor

@alexriedel1 I've merged your PR, but reverted it now since the tests are failing. Will you be able to check why the tests are failing?

Yes sure, will have a look into it today

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 94.73% and no project coverage change

Comparison is base (1407cfc) 86.77% compared to head (433729d) 86.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files         165      165           
  Lines        6319     6322    +3     
=======================================
+ Hits         5483     5486    +3     
  Misses        836      836           
Impacted Files Coverage Δ
...ib/models/components/feature_extractors/torchfx.py 92.98% <94.73%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samet-akcay
Copy link
Contributor Author

@alexriedel1 I've merged your PR, but reverted it now since the tests are failing. Will you be able to check why the tests are failing?

Yes sure, will have a look into it today

Great, thanks a lot!

@samet-akcay samet-akcay requested a review from djdameln March 2, 2023 07:50
@samet-akcay samet-akcay merged commit 78ab50e into main Mar 2, 2023
@samet-akcay samet-akcay deleted the revert-907-mvtec_3d branch March 2, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Notebooks Post-Processing The components that are related to post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants