Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reorder=True argument in aupro #944

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

triet1102
Copy link
Contributor

@triet1102 triet1102 commented Mar 3, 2023

Description

  • Add the reorder=True in the auc() method in the compute() method of AUPRO.

  • Fixes #943

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@github-actions github-actions bot added the Metrics Metric Component. label Mar 3, 2023
@djdameln djdameln self-requested a review March 3, 2023 11:26
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djdameln
Copy link
Contributor

djdameln commented Mar 3, 2023

@samet-akcay @ashwinvaidya17 I mirrored these changes for AUROC metric in #945.

Please note that merging these PRs means that we no longer support PyTorch 1.8 and lower.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c6bd757) 81.34% compared to head (8a8bb11) 81.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files         176      176           
  Lines        6812     6812           
=======================================
  Hits         5541     5541           
  Misses       1271     1271           
Impacted Files Coverage Δ
src/anomalib/utils/metrics/aupro.py 87.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashwinvaidya17
Copy link
Collaborator

@triet1102 sorry for the delay in merging this. We have now migrated from anomalib to anomalib/src. Can you update your PR to point to the file in src

@triet1102 triet1102 closed this Mar 10, 2023
@github-actions github-actions bot removed the Metrics Metric Component. label Mar 10, 2023
@triet1102 triet1102 reopened this Mar 10, 2023
@triet1102
Copy link
Contributor Author

sure!

@samet-akcay
Copy link
Contributor

sure!

Thanks for your patience @triet1102! Our CI was down for some time, which is the reason why this PR had wait a bit

@samet-akcay samet-akcay merged commit d46e1b5 into openvinotoolkit:main Mar 10, 2023
@triet1102 triet1102 deleted the fix/aupro_metric branch March 10, 2023 17:56
@triet1102 triet1102 mentioned this pull request Mar 22, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AUPRO score raise ValueError
4 participants