Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always reorder inputs when computing AUROC #945

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Mar 3, 2023

Description

  • This PR mirrors the changes in add reorder=True argument in aupro #944 in the auroc metric. This was previously not possible, because PyTorch < 1.9 did not support stable sort, which would lead to unpredictable behaviour for duplicate values of fpr/tpr.

!! This means that Anomalib no longer supports PyTorch 1.8 and lower !!
(this should not be an issue because we have PL 1.7.0 in the requirements, which also requires 1.9 or higher)
More details here and here

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@github-actions github-actions bot added the Metrics Metric Component. label Mar 3, 2023
@djdameln djdameln mentioned this pull request Mar 3, 2023
13 tasks
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (c6bd757) 81.34% compared to head (714bbff) 81.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   81.34%   81.33%   -0.01%     
==========================================
  Files         176      176              
  Lines        6812     6809       -3     
==========================================
- Hits         5541     5538       -3     
  Misses       1271     1271              
Impacted Files Coverage Δ
src/anomalib/utils/metrics/auroc.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot removed the Metrics Metric Component. label Mar 10, 2023
@samet-akcay samet-akcay merged commit 6834e5b into openvinotoolkit:main Mar 10, 2023
@triet1102 triet1102 mentioned this pull request Mar 22, 2023
13 tasks
@djdameln djdameln deleted the auroc-metric-reorder branch December 4, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants