Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[Op#51376]: remove wrapping flex container that is causing caption and input group to be squeezed together #143

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

akabiru
Copy link
Member

@akabiru akabiru commented Jul 9, 2024

What are you trying to accomplish?

https://community.openproject.org/wp/51376

There is no longer adequate spacing between the caption and input group. The flex containers seem squashed together Let's use the simpler option

Follows #71

Screenshots

Before
screenshot of caption and group squeezed together

After

screenshot of preview with spacing between caption and input group

screenshot in OP with correct spacing

List the issues that this change affects.

https://community.openproject.org/wp/51376

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

There is no longer adequate spacing between the caption and input group. The flex containers seem squashed together
Let's use the simpler option

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 934431c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented Jul 9, 2024

Uh oh! @akabiru, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

There is no longer adequate spacing between the caption and input group. The flex containers seem squashed together
Let's use the simpler option
@akabiru akabiru changed the title chore[Op#51376]: remove wrapping flex container chore[Op#51376]: remove wrapping flex container that is causing caption and input group to be squeezed together Jul 9, 2024
@akabiru akabiru marked this pull request as ready for review July 9, 2024 12:21
@akabiru akabiru requested a review from HDinger July 9, 2024 12:25
Copy link
Collaborator

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HDinger HDinger merged commit 3b55768 into main Jul 9, 2024
39 checks passed
@HDinger HDinger deleted the bug/51376-fix-spacing branch July 9, 2024 12:37
@openprojectci openprojectci mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants