-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/51376 - Support Primer::OpenProject::InputGroup
caption
#71
Bug/51376 - Support Primer::OpenProject::InputGroup
caption
#71
Conversation
🦋 Changeset detectedLatest commit: 566408a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Stale- will re-open when working on it |
d812d83
to
7b3561f
Compare
Uh oh! @akabiru, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
Primer::OpenProject::InputGroup
captionsPrimer::OpenProject::InputGroup
captions
Primer::OpenProject::InputGroup
captionsPrimer::OpenProject::InputGroup
caption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very well! Thanks @akabiru 🥳 I have one minor remark. Further, could you please add the caption to the "playground" preview as well?
`Primer::Beta::Text` is _a wrapper component that will apply typography styles to the text inside._ Hence semantically it does not fit the use case, and we'd rather call up the chain. Co-authored-by: Henriette Darge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @akabiru 🙇 👍
What are you trying to accomplish?
https://community.openproject.org/wp/51376
Support first party caption on the
Primer::OpenProject::InputGroup
component- providing the caption via thetext_input
breaks the traling_action layout, hence the system argument is also denied.Should resolve FIXME: https://github.com/opf/openproject/blob/dev/modules/storages/app/components/storages/admin/forms/redirect_uri_form_component.html.erb#L29-L34
Screenshots
before
After
Integration
Yes
List the issues that this change affects.
https://community.openproject.org/wp/51376
Risk Assessment
What approach did you choose and why?
Split out the caption into it's own flex container so it's isolated from the text input + trailing input action