Switch to clippy nightly #2037
Merged
Switch to clippy nightly #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soenkehahn
commented
Apr 22, 2023
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| components: clippy, rustfmt | ||
| components: rustfmt | ||
| override: true | ||
| toolchain: stable |
There was a problem hiding this comment.
rustfmt is still installed as the stable version.
soenkehahn
commented
Apr 22, 2023
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| key: "clippy-nightly" |
There was a problem hiding this comment.
Hopefully this will mean that -- once we revert this PR -- we will not suffer from bigger caches anymore.
Should be reverted once rust-lang/rust-clippy#10502 is released in a stable `clippy`.
soenkehahn
force-pushed
the
sh/fix-clippy
branch
from
1fcb505 to
3da65ee
Compare
Closed
|
Nice, merged! |
popcnt1
pushed a commit
to popcnt1/ord
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches
clippytonightly, both in ci scripts and forjust clippyand friends. This is to workaround this issue, which I believe is fixed here, but hasn't landed in the stable version ofclippy. This PR should be reverted once the fix lands.Fixes #2035.
Of course this has some downsides:
clippyis not stable, so we may have some CI issues introduced in newer nightly versions. (We could try to pin downclippyto an exact nightly version, which would avoid this. Any opinions?)just clippy(or e.g.just ci) you have to runrustup install nightly.