Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to clippy nightly #2037

Merged
merged 1 commit into from
Apr 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,25 @@ jobs:
steps:
- uses: actions/checkout@v2

- name: Install Rust Toolchain Components
- name: Install rustfmt
uses: actions-rs/toolchain@v1
with:
components: clippy, rustfmt
components: rustfmt
override: true
toolchain: stable
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustfmt is still installed as the stable version.


- name: Install clippy nightly
uses: actions-rs/toolchain@v1
with:
components: clippy
toolchain: nightly

- uses: Swatinem/rust-cache@v2
with:
key: "clippy-nightly"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will mean that -- once we revert this PR -- we will not suffer from bigger caches anymore.


- name: Clippy
run: cargo clippy --all --all-targets
run: cargo +nightly clippy --all --all-targets

- name: Format
run: cargo fmt --all -- --check
Expand Down
4 changes: 2 additions & 2 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ fmt:
cargo fmt

clippy:
cargo clippy --all --all-targets -- -D warnings
cargo +nightly clippy --all --all-targets -- -D warnings

lclippy:
cargo lclippy --all --all-targets -- -D warnings
cargo +nightly lclippy --all --all-targets -- -D warnings

deploy branch chain domain:
ssh root@{{domain}} "mkdir -p deploy \
Expand Down