Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Julia0.6 support #64

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Julia0.6 support #64

wants to merge 6 commits into from

Conversation

oxinabox
Copy link
Owner

@oxinabox oxinabox commented Aug 3, 2018

This is a PR to track julia 0.6 backports.

They will go onto version 0.4.x

Don't merge it.

@codecov-io
Copy link

codecov-io commented Aug 18, 2018

Codecov Report

Merging #64 into master will decrease coverage by 18.77%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #64       +/-   ##
===========================================
- Coverage   81.75%   62.97%   -18.78%     
===========================================
  Files          12       12               
  Lines         148      235       +87     
===========================================
+ Hits          121      148       +27     
- Misses         27       87       +60
Impacted Files Coverage Δ
src/resolution_automatic.jl 58.13% <100%> (-6.15%) ⬇️
src/util.jl 41.93% <0%> (-41.4%) ⬇️
src/resolution.jl 72.72% <0%> (-27.28%) ⬇️
src/post_fetch_helpers.jl 45.83% <0%> (-18.88%) ⬇️
src/fetch_helpers.jl 85.71% <0%> (-14.29%) ⬇️
src/verification.jl 86.66% <0%> (-13.34%) ⬇️
src/registration.jl 87.5% <0%> (-12.5%) ⬇️
src/locations.jl 87.5% <0%> (-6.25%) ⬇️
src/resolution_manual.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b301a...19e3e0d. Read the comment docs.

add a warning if the old one (DATADEPS_ALWAY_ACCEPT) is used, check
both, prefer DATADEPS_ALWAYS_ACCEPS.
@oxinabox
Copy link
Owner Author

oxinabox commented Nov 8, 2018

Ok good that passed tests,
tagging a release on this branch.
called 0.4.3

@oxinabox
Copy link
Owner Author

oxinabox commented Nov 8, 2018

released 0.4.3, with backported environment var name fix
JuliaLang/METADATA.jl#19393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants