Do cleanup if there is an error mid-download #68
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 81.75% 82.23% +0.48%
==========================================
Files 11 11
Lines 148 152 +4
==========================================
+ Hits 121 125 +4
Misses 27 27
Continue to review full report at Codecov.
|
|
@Evizero can I borrow a code review? |
test/main.jl
Outdated
|
|
||
|
|
||
| @show dummydown | ||
| @show dummyhash |
There was a problem hiding this comment.
these look like leftover debug statements
test/main.jl
Outdated
| register(DataDep("TestErrorChecksum", "dummy message", "http://example.void", | ||
| (error, "1234"); # this will throw an error | ||
| fetch_method=dummydown)) | ||
| @test_throws Exception datadep"TestErrorChecksum" |
There was a problem hiding this comment.
not super important, but you could use an ErrorException here to be just a tiny bit more confident that you are catching the error you expect to catch
There was a problem hiding this comment.
Good point. I remember thinking that. I don't know why I didn't
|
Can you think of a situation where you would not automatically want to remove the |
Yeah, I was wondering about that. Folder already exists and is non-empty. What would you like to do? |
Resolves #66 (comment)
This can't be merged until JuliaLang/METADATA.jl#17037
Because it needed new version of ExpectationStubs.jl for tests
A version that doesn't require that will be back-ported to 0.6 see #64