--load-modules option for simple_switch_grpc #719
Comments
antoninbas
added a commit
that referenced
this issue
Feb 21, 2019
Since this is useful for many targets (simple_switch, simple_switch_grpc and possibly psa_switch) and has been around for a while, I decided to move support for --load-modules to the core bmv2 library, by adding a new reference target-specific option parser (`TargetParserBasicWithDynModules`) that targets can use directly. The reason why this functionality did not find its way into the main bmv2 option parser is because it requires the target to be linked with -rdynamic, so I believe it is better for the target to choose whether this functionality is required or not. Not moving it to the main option parser also guarantees backward-compatibility for simple_switch users. Fixes #719
antoninbas
added a commit
that referenced
this issue
Feb 21, 2019
Since this is useful for many targets (simple_switch, simple_switch_grpc and possibly psa_switch) and has been around for a while, I decided to move support for --load-modules to the core bmv2 library, by adding a new reference target-specific option parser (`TargetParserBasicWithDynModules`) that targets can use directly. The reason why this functionality did not find its way into the main bmv2 option parser is because it requires the target to be linked with -rdynamic, so I believe it is better for the target to choose whether this functionality is required or not. Not moving it to the main option parser also guarantees backward-compatibility for simple_switch users. Fixes #719
|
I pushed a patch for this. In the future, providing the organization (company or university) you belong to us a p4.org member (https://p4.org/members/), don't hesitate to submit a patch yourself for new features you care about. |
antoninbas
added a commit
that referenced
this issue
Feb 21, 2019
Since this is useful for many targets (simple_switch, simple_switch_grpc and possibly psa_switch) and has been around for a while, I decided to move support for --load-modules to the core bmv2 library, by adding a new reference target-specific option parser (`TargetParserBasicWithDynModules`) that targets can use directly. The reason why this functionality did not find its way into the main bmv2 option parser is because it requires the target to be linked with -rdynamic, so I believe it is better for the target to choose whether this functionality is required or not. Not moving it to the main option parser also guarantees backward-compatibility for simple_switch users. Fixes #719
|
Thank you. Neither I nor my organization is a p4.org member. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Are there any plans to add the --load-modules option to simple_switch_grpc as well? At the moment, it is only available for simple_switch.
Judging by the original pull request, the amount of code that would have to be changed looks relatively small, and the option is really useful.
The text was updated successfully, but these errors were encountered: