Support --load-modules option for simple_switch_grpc #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 74.81% 74.69% -0.13%
==========================================
Files 114 115 +1
Lines 9874 9894 +20
==========================================
+ Hits 7387 7390 +3
- Misses 2487 2504 +17
Continue to review full report at Codecov.
|
Since this is useful for many targets (simple_switch, simple_switch_grpc and possibly psa_switch) and has been around for a while, I decided to move support for --load-modules to the core bmv2 library, by adding a new reference target-specific option parser (`TargetParserBasicWithDynModules`) that targets can use directly. The reason why this functionality did not find its way into the main bmv2 option parser is because it requires the target to be linked with -rdynamic, so I believe it is better for the target to choose whether this functionality is required or not. Not moving it to the main option parser also guarantees backward-compatibility for simple_switch users. Fixes #719
antoninbas
force-pushed
the
antonin/support-load-modules-option-for-simple-switch-grpc
branch
from
afaaf45 to
b87107c
Compare
antoninbas
deleted the
antonin/support-load-modules-option-for-simple-switch-grpc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is useful for many targets (simple_switch, simple_switch_grpc
and possibly psa_switch) and has been around for a while, I decided to
move support for --load-modules to the core bmv2 library, by adding a
new reference target-specific option parser
(
TargetParserBasicWithDynModules) that targets can use directly. Thereason why this functionality did not find its way into the main bmv2
option parser is because it requires the target to be linked with
-rdynamic, so I believe it is better for the target to choose whether
this functionality is required or not. Not moving it to the main option
parser also guarantees backward-compatibility for simple_switch users.
Fixes #719