Persist isCompacted status of SSTables and scrub on startup #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wi11dey
force-pushed
the
wdey/scrub-compacted-marker
branch
from
3291113 to
f415b6f
Compare
wi11dey
force-pushed
the
wdey/scrub-compacted-marker
branch
from
5f5ae1e to
4458362
Compare
[skip ci]
wi11dey
force-pushed
the
wdey/scrub-compacted-marker
branch
from
f4b14d7 to
0c460ba
Compare
[skip ci]
tpetracca
reviewed
Aug 19, 2024
| @@ -1691,7 +1691,7 @@ public boolean markObsolete(Tracker tracker) | |||
| { | |||
| assert !tidy.isReplaced; | |||
| } | |||
| if (!tidy.global.isCompacted.getAndSet(true)) | |||
| if (!tidy.global.setCompacted()) | |||
There was a problem hiding this comment.
note during review:
- this is the only place in the code
isCompactedwas getting set to true setCompactedis synchronized
thus the former atomic call to getAndSet is still mirrored in this change
tpetracca
reviewed
Aug 19, 2024
rhuffy
reviewed
Aug 20, 2024
rhuffy
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a table finished compaction as it is being streamed, the streaming will still hold a ref on the compaction ancestor. If the node crashes in this state, the next reboot will read both the ancestor and the compacted SSTable without any tombstones that arrived and got compacted during streaming.