Alternate method of ensuring no compacted SSTables left at startup #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wi11dey
force-pushed
the
wdey/alternate-scrub-obsolete-sstable
branch
from
083bcea to
946e6b6
Compare
[skip ci]
rhuffy
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColumnFamilyStore.removeUnfinishedCompactionLeftovers removes any SSTables that are part of another SSTable's compaction ancestors on startup. The reason this didn't help #521 is because it only runs when there are pending compactions on a given ks.cf, which isn't the case if you're just holding a ref post-successful-compaction. This PR changes startup code so that removeUnfinishedCompactionLeftovers runs on every ks.cf unconditionally
Functionally, the only changes are removeUnfinishedCompactionLeftovers is run in more cases than it was previously. It is always safe to run since it will only delete SSTables that are positively listed as an ancestor of another sstable