-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regenerate interface code on thrift 0.17.0 #577
base: palantir-cassandra-2.2.18
Are you sure you want to change the base?
Conversation
@@ -794,7 +794,7 @@ | |||
description="Generate Thrift Java artifacts"> | |||
<echo>Generating Thrift Java code from ${basedir}/interface/cassandra.thrift...</echo> | |||
<exec executable="thrift" dir="${basedir}/interface" failonerror="true"> | |||
<arg line="--gen java:hashcode" /> | |||
<arg line="--gen java" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This argument was removed in 0.9.2
for THRIFT-2263 via apache/thrift@acdac81
Before 0.9.2
thrift's java impl did not generate equals()
and hashcode()
methods for classes by default unless the hashcode
flag was set. As of 0.9.2
those methods are generated by default.
@@ -25,7 +25,6 @@ | |||
|
|||
namespace java org.apache.cassandra.thrift | |||
namespace cpp org.apache.cassandra | |||
namespace csharp Apache.Cassandra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The csharp
generator was deprecated in thrift 0.13.0
and removed in 0.14.0
. We don't have any C# cassandra thrift clients, so it doesn't matter.
I attempted the codegen locally and it included a license header on each file. Are you intentionally removing those headers? |
I've also created a homebrew tap that should make it easier install thrift in thrift in the future
|
In #432 we manually modified the generated code in order to bump the runtime dependency on libthrift to 0.17.0, so now we can't make changes to thrift and re-generate without having to re-apply the manual changes.
This change updates the code-gen to be generated from thrift 0.17.0, which shouldn't require the manual changes anymore.
In order to install thrift 0.17.0 locally I used an old git commit of the Homebrew source and installed from like this...