Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies after installation with [email protected] #106

Closed
k7sleeper opened this issue Jul 12, 2017 · 4 comments
Closed

Missing dependencies after installation with [email protected] #106

k7sleeper opened this issue Jul 12, 2017 · 4 comments

Comments

@k7sleeper
Copy link

After installation of tslint-react with npm v5.2.0 I got a

Warning: Cannot find module 'tsutils' Use --force to continue.

After digging through the sources I found that rules implementations (i.e. tslint-react/rules/jsxAlignmentRule.js) require node modules tslint, typescript and tslint but not any of these modules is listed in dependencies or peerDependencies.

@andreyctkn
Copy link

yep, the same situation.

@andreyctkn
Copy link

@k7sleeper sounds that it has already fixed in npm 5.3.0. Please check.

@k7sleeper
Copy link
Author

k7sleeper commented Jul 17, 2017

Well, I try!

I thougth that tslint, typescript and tslint are missing dependencies in package.json of this project, aren't they? They aren't merely dev dependencies but dependencies, are they?

@k7sleeper
Copy link
Author

With [email protected] I get no error message!

But, as I asked above: haven't tslint, typescript and tslint be listed in dependencies?

adidahiya added a commit that referenced this issue Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants