Explicit peer dependencies

[adidahiya]

Fixes #106

[timocov]

@adidahiya why tsutils is in peerDependencies instead of be in dependencies?

[timocov]

I guess it is similar to microsoft/tslint-microsoft-contrib#371

[adidahiya]

Meh, this is kind of the reason I never listed explicit peer dependencies in the first place (it gets tedious to maintain and doesn't provide many benefits). The whole idea here is to prevent multiple versions of tsc from being used in TSLint and its rule implementations at runtime. If I make tsutils a regular dependency then I believe there's a possibility that NPM could install a nested typescript module inside tsutils/node_modules and now we have two versions in use at runtime (despite the fact that typescript itself is a peer dependency of tslint-react) -- I'll need to double-check this.

[timocov]

I agree, it is good reason.

If I make tsutils a regular dependency then I believe there's a possibility that NPM could install a nested typescript module inside tsutils/node_modules

But typescript is a peer dependency of tsutils (https://github.com/ajafff/tsutils/blob/master/package.json#L43) and I guess that if you use a library with specific API for specific range of versions you should make it as dependency.

[timocov]

And now with [email protected] we have an error about not-installed tsutils for tslint-react (yeah, it is bug of npm but I guess package.json of tslint-react should has tsulits as deps)

[adidahiya]

@ajafff do you have any opinions here?

[ajafff]

As @timocov said, tsutils has typescript in peerDependencies. Hence there will only be one version of typescript installed.

The only reason to put tsutils in peerDependencies is to avoid different (major) versions of it in tslint and rules packages. But I don't think that's necessary.

[adidahiya]

@ajafff given that logic, it should probably be safe to make tslint also a regular dependency here then? Since it also declares typescript as a peer.

[timocov]

I think that tslint should be peer dependency because tslint-react is plugin for tslint. Yes, tslint-react depends on tslint but in development only and just for typings. (https://nodejs.org/en/blog/npm/peer-dependencies/)

[ajafff]

I agree with @timocov. A plugin should not bring it's own version of the library it plugs into.

Take vrsource-tslint-rules for example: It has a regular dependency on tslint@^4.1.1. You can install this package even if you have tslint@^5.0.0 installed. You won't notice any incompatibility until you experience a runtime crash.