Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade rector, current rector is broken with latest phpstan release #284

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

bbrala
Copy link
Collaborator

@bbrala bbrala commented Jan 11, 2024

Description

See: rectorphp/rector#8395

To Test

Run tests <3

Drupal.org issue

no.

Rector\Core -> Rector
Added NodeTraverser::REMOVE_NODE to phpstan baseline since new constant is not yet available.
Fixed codestyle
@bbrala
Copy link
Collaborator Author

bbrala commented Jan 11, 2024

Fixes for rector 0.19

Rector\Core -> Rector
Added NodeTraverser::REMOVE_NODE to phpstan baseline since new constant is not yet available.
Fixed codestyle

bbrala and others added 4 commits January 11, 2024 09:51
Rector\Core -> Rector
Added NodeTraverser::REMOVE_NODE to phpstan baseline since new constant is not yet available.
Fixed codestyle
Copy link
Collaborator

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and handles PhpParser update

Copy link
Contributor

@agentrickard agentrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and installs as expected.

@bbrala bbrala merged commit 4f67d28 into main Jan 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants